Test: new when-clauses parser

[ulugbekna]

Refs: #91473

• anyOS @eleanorjboyd
• anyOS @alexr00

Complexity: 3

Create Issue

---

Summary

We rewrote the parser for when-clauses (docs, new parser changes) with various new features - most important of which are

• support for parenthesized expressions, eg (a || b) && c or !(a || b)
• linter for when clauses in an extension manifest file package.json

Testing

1. Clone https://github.com/ulugbekna/ctxkey-extension
2. Run yarn inside the cloned repo
3. Run vscode instance with that extension - just pressing F5 should launch such an instance
4. In the newly open vscode instance:

test 1

1. Open a json file (just creating a new untitled file (cmd+n) and selecting language JSON should suffice)
2. Search "hello" in command palette - you should only see "Hello world - present 1" command

test 2

1. Open any file but not json and not python
2. Search "hello" in command palette - you should only see "Hello world - present 2" and "Hello world - present 3" commands
3. Open a python file
4. Search "hello" in command palette - you should not see "Hello world - present 3"

test 3

1. Go back to vscode instance with the cloned repo
2. Edit the "when" clauses according to the docs and notice if the reported errors look good to you

       {
          "command": "ctxkey-extension.helloWorld1",
          "when": "!(editorLangId === json || editorLangId === python)" // <- this is a when clause; you want to edit the value of this field, e.g., remove a closing parenthesis, etc. 
        },

[alexr00]

Works very nicely! I've cleaned up some of the whens in GHPRI: microsoft/vscode-pull-request-github#4651

[ulugbekna]

@eleanorjboyd: Alex proposed that she rather cleans up when-clauses in the extension she maintains and verifies the contributions still work with the new parser & the linter reports good errors in package.json -- if you prefer, you can do the same rather than using the sample-extension that I provide.

[eleanorjboyd]

@ulugbekna, thanks for the sample extension! I used it and it went great!

[ulugbekna]

@eleanorjboyd thanks for verifying and sorry for the wrong instruction!