Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test improved New File... experience #155731

Closed
4 tasks done
lramos15 opened this issue Jul 20, 2022 · 4 comments
Closed
4 tasks done

Test improved New File... experience #155731

lramos15 opened this issue Jul 20, 2022 · 4 comments

Comments

@lramos15
Copy link
Member

lramos15 commented Jul 20, 2022

Refs #153860

Complexity: 2

Create Issue


In an effort to help users who get stuck creating a file via File > New File... and to enrich the file creation experience the input box now allows for creating files on disk by typing a file name.

Please test the following workflows via File > New File... or clicking New File... on the walkthrough.

  1. Typing a file name and creating a file
  2. Typing an invalid file name
  3. Overwriting an existing file. Please ensure you are prompted before the overwrite happens!

General UX feedback is also always appreciated :)

@sadasant
Copy link

Here's creating a new file on linux:

newfile.mov

Here's overwriting that file:

newfileoverwrite.mov

Feedback appreciated! Is there anything else I should specifically try?

@lramos15
Copy link
Member Author

lramos15 commented Jul 26, 2022

Thanks @sadasant no need to make videos (although they are nice). Just testing the steps above and then filing any bugs / things you wouldn't expect while testing is more than enough :)

@rzhao271 rzhao271 assigned rzhao271 and unassigned rzhao271 Jul 28, 2022
@rzhao271
Copy link
Contributor

I like it 🎉

@Yoyokrazy Yoyokrazy self-assigned this Jul 28, 2022
@Yoyokrazy
Copy link
Contributor

Testing on windows, the behavior when typing an invalid file name wasn't necessarily wrong, but felt odd. I attempted to name my file lkdfjhg`~\|.txt just to force in some definitely invalid characters, and the OS prompted me to save the file as |.txt in a file explorer window (followed by an invalid character error if I try to save).

However, trying ??*<>+#.txt gave me an OS file prompt with the same characters followed by an error upon clicking save saying it was invalid.

Not sure what the expected behavior should be here, but a message saying something along the lines of This filename contains invalid characters might be helpful for the user in the case that they use something they shouldn't. Maybe a prompt before the workflow takes the user into the OS file prompt?

@Yoyokrazy Yoyokrazy removed their assignment Jul 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants