Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated terminal key combination not working for dotnet watch #133400

Closed
sergiojrdotnet opened this issue Sep 19, 2021 · 5 comments
Closed

Integrated terminal key combination not working for dotnet watch #133400

sergiojrdotnet opened this issue Sep 19, 2021 · 5 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label windows VS Code on Windows issues
Milestone
Backlog

Comments

@sergiojrdotnet
Copy link

Issue Type: Bug

The integrated terminal does not trigger rebuild command for dotnet watch. The key combination works propertly on external powershell.

Steps to reproduce:

  1. Create/Open a dotnet project
  2. Open the integrated terminal
  3. Run dotnet watch
  4. Press "Ctrl + Shift + R" to restart build

I also have removed all keyboard shortcuts bindings with the same combination and tested with all extensions disabled.

VS Code version: Code 1.60.1 (83bd43b, 2021-09-10T17:07:10.714Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7 CPU 930 @ 2.80GHz (8 x 2803)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: unavailable_off
opengl: enabled_on
rasterization: unavailable_off
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 11.99GB (5.72GB free)
Process Argv --crash-reporter-id 880990b1-7abb-48e6-9ea7-e83c7db45560
Screen Reader no
VM 0%
Extensions (33)
Extension Author (truncated) Version
vscode-base64 ada 0.1.0
es7-react-js-snippets dsz 3.1.1
gitlens eam 11.6.0
vscode-html-css ecm 1.10.2
vscode-npm-script eg2 0.3.22
prettier-vscode esb 8.1.0
vscode-firefox-debug fir 2.9.4
auto-rename-tag for 0.1.8
vscode-pull-request-github Git 0.30.0
svg joc 1.4.10
aspnetcorerazor-html-css-class-completion kev 1.0.3
vscode-scss mrm 0.10.0
vscode-docker ms- 1.16.1
blazorwasm-companion ms- 1.1.0
csharp ms- 1.23.15
vscode-dotnet-runtime ms- 1.2.0
vscode-kubernetes-tools ms- 1.3.3
mssql ms- 1.10.1
python ms- 2021.9.1230869389
vscode-pylance ms- 2021.9.2
jupyter ms- 2021.8.2041215044
jupyter-keymap ms- 1.0.0
remote-containers ms- 0.194.0
remote-wsl ms- 0.58.2
cpptools ms- 1.6.0
js-debug-nightly ms- 2021.9.1717
powershell ms- 2021.9.0
vetur oct 0.34.1
vscode-thunder-client ran 1.9.1
vscode-yaml red 0.22.0
LiveServer rit 5.6.1
vscodeintellicode Vis 1.2.14
markdown-all-in-one yzh 3.4.0

(1 theme extensions excluded)

A/B Experiments 
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
pythonvspyt700cf:30270857
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551:30345470
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30358481
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
vscextlangct:30333562
binariesv615:30325510
vsccppwtct:30364498
pythonvssor306:30344512
bridge0708:30335490
pygetstartedt2:30360495
bridge0723:30353136
pythonrunftest32:30365366
pythonf5test824:30361777
javagetstartedt:30364666
pythonvspyt187cf:30365362
pydsgsc2:30361791
vssid140cf:30363604
vssur157:30367808
@meganrogge
Copy link
Contributor

does setting terminal.integrated.sendKeybindingsToShell: true help?

@meganrogge meganrogge added the info-needed Issue requires more information from poster label Sep 27, 2021
@sergiojrdotnet
Copy link
Author

Hi @meganrogge, it still does not work

@meganrogge meganrogge added terminal General terminal issues that don't fall under another label terminal-triage and removed info-needed Issue requires more information from poster labels Oct 6, 2021
@Tyriar
Copy link
Member

Tyriar commented Oct 13, 2021

Does the same happen when you try in Windows Terminal? I'm guessing this is because ptys don't encode ctrl+shift+key but the Windows Console API does.

@Tyriar Tyriar added info-needed Issue requires more information from poster windows VS Code on Windows issues and removed terminal-triage labels Oct 13, 2021
@sergiojrdotnet
Copy link
Author

sergiojrdotnet commented Oct 14, 2021 •
edited
Loading

Yes, it works on Windows Terminal too. However, .NET team has changed the key combination to Ctrl + R on .NET 6 RC 2, maybe because they also detected the issue with integrated terminal.

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Oct 19, 2021
@meganrogge meganrogge added this to the Backlog milestone Oct 19, 2021
@Tyriar
Copy link
Member

Tyriar commented Oct 19, 2021

This needs us to adopt win32 input mode: #135127

/duplicate

@Tyriar Tyriar closed this as completed Oct 19, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label windows VS Code on Windows issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@Tyriar @meganrogge @sergiojrdotnet and others