Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does a user know what settings are overridden by an extension? #12799

Closed
Tyriar opened this issue Sep 27, 2016 · 6 comments
Closed

How does a user know what settings are overridden by an extension? #12799

Tyriar opened this issue Sep 27, 2016 · 6 comments
Assignees
Labels
api *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality ux User experience issues

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 27, 2016

Steps to Reproduce:

  1. Set "terminal.integrated.cursorBlinking": true in your settings.json

  2. Run an extension containing:

    vscode.workspace.getConfiguration()
      .update('terminal.integrated.cursorBlinking', false, false);
  3. Try to figure out why "terminal.integrated.cursorBlinking": true is not working

  4. File a bug to Microsoft/vscode

@Tyriar Tyriar added important Issue identified as high-priority api ux User experience issues labels Sep 27, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Sep 27, 2016

I realized shortly after this that it's in ./.vscode/settings.json, not local storage. Most users will be unaware of this though, don't we owe users some warning before an extension goes and messes with their settings files?

I was expecting the changes to be stored elsewhere, perhaps with a warning annotation within the settings.json file indicating that an extension has overridden an extension. If I were a normal user without my settings.json source controlled and symlinked to I would be very irritated if an extension messed with it. Especially if I then uninstalled the extension and it didn't revert the change.

@Tyriar Tyriar removed the important Issue identified as high-priority label Sep 27, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Sep 27, 2016

I realize this would be a complete change in how it's handled but I think a model like this is worth consideration for the future to protect settings and make sure installing and then uninstalling an extension doesn't change the way that the editor behaves.

@Tyriar Tyriar added the feature-request Request for new features or functionality label Sep 27, 2016
@bpasero
Copy link
Member

bpasero commented Sep 27, 2016

@Tyriar isn't this covered in #10583

@Tyriar
Copy link
Member Author

Tyriar commented Sep 27, 2016

@bpasero that only cares about the extension author perspective doesn't it, not surfacing the information to the user?

@bpasero
Copy link
Member

bpasero commented Sep 27, 2016

@Tyriar ok I see what you mean. there is no information, it is up to an extension to decide if a message should be shown or not. in the end this is just API to write to the settings file.

@jrieken
Copy link
Member

jrieken commented Sep 28, 2016

dup of #10583

@jrieken jrieken closed this as completed Sep 28, 2016
@jrieken jrieken added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 28, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality ux User experience issues
Projects
None yet
Development

No branches or pull requests

3 participants