Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: breakpoint conditions #114345

Closed
2 tasks done
isidorn opened this issue Jan 14, 2021 · 3 comments
Closed
2 tasks done

Test: breakpoint conditions #114345

isidorn opened this issue Jan 14, 2021 · 3 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jan 14, 2021

Refs: #3646 #113805 #104453

Complexity: 3

Create Issue


We have made changes to the breakpoints view. Have a javascript project, for example our smoke test express app. Add some breakpoints in a file, add some function breakpoints (click + in the Breakpoints view title) and verify:

  • You can edit the condition of regular breakpoints, exception breakpoints and function breakpoints by clicking on the inline Edit icon
  • You can use the Context Menu action to also edit the condition and hit condition of Exception Breakpoints and Function Breakpoints
  • Once a breakpoints has a condition it is nicely rendered in the breakpoints view and can be seen on hover (note that for regular breakpoints we only show condition on hover, since there is not enough space - we render the breakpoint path)

If you start on this testplan before endgame begins, make sure to use js-debug-nightly

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item labels Jan 14, 2021
@isidorn isidorn added this to the January 2021 milestone Jan 14, 2021
@isidorn isidorn changed the title Test: breakopint conditions Test: breakpoint conditions Jan 14, 2021
@microsoft microsoft deleted a comment from github-actions bot Jan 14, 2021
@connor4312
Copy link
Member

Sure, we can use this for validating the js-debug implementation as well.

@connor4312
Copy link
Member

@TylerLeonhardt / @rzhao271 use mock debug to test function breakpoints. js-debug does not support function breakpoints/

@rzhao271
Copy link
Contributor

Not sure how to hit the function breakpoints for Mock Debug on markdown files, but editing the breakpoint while running the markdown file lgtm.

@rzhao271 rzhao271 removed their assignment Jan 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Development

No branches or pull requests

4 participants