Annoying notification from the internal git extension keeps popping up

[brezanac]

Issue Type: Bug

The integrated Git extension, that comes bundled with Visual Studio Code, currently displays a notification about a newer Git version every time VSCode is started.

This means that there is no way to disable the notification, at least not that I know of.

The problem lies in the fact that Git for Windows 2.27 and newer come with a number of very annoying bugs which force people to stay with version 2.26.2.

Bottom line is - I would like not to be forced to see these notifications every single time VSCode is started. Is there any way to disable them?

VS Code version: Code 1.47.0 (d5e9aa0, 2020-07-09T08:02:06.629Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz (8 x 4000)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.91GB (8.24GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (17)

Extension	Author (truncated)	Version
html-snippets	abu	0.2.1
Bookmarks	ale	11.3.1
dart-code	Dar	3.12.2
flutter	Dar	3.12.2
vscode-eslint	dba	2.1.6
gitlens	eam	10.2.2
eml	lei	0.4.0
rainbow-csv	mec	1.7.0
git-graph	mhu	1.24.0
dotenv	mik	1.0.1
vscode-docker	ms-	1.3.1
remote-wsl	ms-	0.44.4
vetur	oct	0.24.0
material-icon-theme	PKi	4.2.0
LiveServer	rit	5.6.1
code-settings-sync	Sha	3.4.3
material-theme	zhu	3.8.3

[joaomoreno]

What specific issues with 2.27 are you referring to?

The fact is that 2.25 and 2.26 are really broken with VS Code, so it is important that we tell users to update.

But we can add an option to never ask again, sure, I'll keep this issue open to address that.

[brezanac]

What specific issues with 2.27 are you referring to?

There are several serious issues with Git for Windows 2.27, one of them even reported by me here regarding problems with PEM based private keys (old format) and weird behavior of the bundled ssh client. Some people claim that the resolution provided in the comments resolves their issues but me and a lot of collegues still have terrible issues with the ssh client.

Because of that I can't use anything newer than Git for Windows 2.26.2. until I have a definitive proof that one of the newer stable versions resolves the issue (for now version 2.28 RC does not either).

The notification just adds salt to the wound and the confusing part is that even though it's marked as enabled globally (I guess that means it can't be disabled) there is no option to supress the notification.

[joaomoreno]

I believe you mean 2.27, 2.26 and 2.28 RC.

Yeah, we'll add a suppress option.

[brezanac]

I believe you mean 2.27, 2.26 and 2.28 RC.

Yeah, we'll add a suppress option.

Yeah, sorry, my bad. I meant 2.27 and up. I corrected all the references.

Thank you.

[aolszowka]

FWIW Git 2.27 breaks the git svn bridge (Fixed in the latest prerelease), I got "taken" by the VS Code Update Dialog as well.

[lptr]

What are the things that are broken with 2.26? It would be great if the notification linked to some more information. I couldn't find anything about serious problems fixed in Git 2.27 about Windows or VSCode in the Git release notes.

It seems that 2.27 is not a good option either. Is a downgrade possible? If so, it would be useful if the message hinted at a good version number.

[lptr]

This comment suggests 2.25 could be a good option: #98967 (comment)

[JasonGore]

We also ran into issues with git 2.27 preventing us from adopting it. These types of popups would also do well to list actual git issues motivating their appearance so that devs can balance between the issues at play to make a final decision.

[kenotron]

It looks we're doing this notification based on known issues of old git versions:
#98967

But it looks like we also many known issues of git 2.27:
git-for-windows/git#2732

We need to be careful not to nag at users who have certain versions of git installed. git "api" isn't really changing that quickly - unless it breaks internals of vscode, I would heavily lobby AGAINST having any notifications like this at all. We should get rid of this notification altogether.

[lptr]

@kenotron fully agree. Another option is to selectively disable features that are known to be problematic, or better yet, fall back to slower / less convenient behavior. Disabling all of Git functionality is too much.

[joaomoreno]

We need to be careful not to nag at users who have certain versions of git installed. git "api" isn't really changing that quickly - unless it breaks internals of vscode, I would heavily lobby AGAINST having any notifications like this at all. We should get rid of this notification altogether.

The current nag exists because we receive many issues because of the way Git 2.25-26 breaks path handling on Windows. These issues are resolved in 2.27.

Another option is to selectively disable features that are known to be problematic

The issue in question is basic git functionality: staging a file doesn't work. We simply can't disable that.

[lptr]

The current nag exists because we receive many issues because of the way Git 2.25-26 breaks path handling on Windows. These issues are resolved in 2.27.

This should be clarified in the message at least. I just got our infra team to upgrade to 2.27, only to read the comments here, after which I asked them to downgrade to 2.25. (From this comment I assumed it was a good version: #98967 (comment)). I guess we should downgrade to 2.24?

The issue in question is basic git functionality: staging a file doesn't work. We simply can't disable that.

I haven't noticed problems using Git 2.26 on Windows using it from the command-line, so I'm wondering what exactly it is that doesn't work, and if some basic functionality could be provided despite the errors. It feels unlikely that two entire releases on Git (2.25 and 2.26) are completely broken to the point of uselessness.

[joaomoreno]

Here are the issues: https://github.com/microsoft/vscode/issues?q=is%3Aissue+2.27+is%3Aclosed

It's related to git behaving stricter in terms of letter casing with a path's drive letter.

[isidorn]

I have verified via code review that we introduced an appropriate setting.