Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show Editor Actions in Diff Editor #18559

Closed
iamhammer opened this issue Jan 16, 2025 · 2 comments · Fixed by #18608
Closed

Don't show Editor Actions in Diff Editor #18559

iamhammer opened this issue Jan 16, 2025 · 2 comments · Fixed by #18608
Assignees
Labels
Area - Query Editor User-filed Filed by a public user

Comments

@iamhammer
Copy link

When looking at the git diff of a SQL script, the editor actions that are added by this extension (Execute Query, Reveal Query Results Panel, Estimated Plan, etc.) bump off the more relevant editor actions when viewing a file diff (Previous Change, Next Change, Swap Left and Right Side).

If I am viewing two versions of a SQL query, having a single execute button is a little ambiguous and problematic.

Can these editor actions be hidden from the diff editor context?

@caohai caohai self-assigned this Jan 29, 2025
@caohai caohai added Area - Query Editor User-filed Filed by a public user labels Jan 29, 2025
@caohai
Copy link
Member

caohai commented Jan 29, 2025

Thank you for filing the issue, this makes sense. I'll send out a PR fixing this behavior in the next few days.

@caohai
Copy link
Member

caohai commented Jan 29, 2025

A fix for this has been merged to main and will go out with the Feb release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Query Editor User-filed Filed by a public user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants