LSP request failure toasts cannot be turned off

[dibarbet]

Not sure if this is an issue here or on the vscode side (or intentional behavior) - but toast notifications due to a failed LSP request cannot be turned off.

To repro

1. Clone and open the vscode extension samples LSP sample - https://github.com/microsoft/vscode-extension-samples/tree/main/lsp-sample
2. add a line to throw an error in the completion request
3. run the extension and trigger completion
4. note the failure toast, and attempt to turn off the notifications for the extension

5. dismiss the failure, re-invoke completion and note that the toast continues to show up.

Was reported in dotnet/vscode-csharp#6977
We're attempting to fix the issues causing the request to fail, but it seems like a bug that the notifications cannot be turned off.

[dbaeumer]

@bpasero is there anything special I need to do. When I press the Manage Extension button I get this:

[bpasero]

@dbaeumer errors are excempted from notification ignore. Only info and warning can be ignored.

[dibarbet]

errors are excempted from notification ignore.

I thought it might be something like that. If that is the behavior, being able to configure the notification ignore from an error notification can be a little misleading.

[bpasero]

Yeah I do understand, will think about it. I am not a big fan of just not showing this action based on severity because it may still be hard for a user to understand what conditions there are to hide it.

[dbaeumer]

I will close the issue then.

[garrettlondon1]

@bpasero @dbaeumer Thank you for your consideration of this issue.

Please review dotnet/vscode-csharp#6977 , as this is an extension which uncontrollably throws errors.

From a Accessibility perspective, not giving users the ability to disable errors, or extension authors ability, leaves VS code in a state where errors are coming up all the time, even in Zen Mode

Would you please consider reopening this ticket, as it is a huge accessibility pain and am unable to work properly with the C# extension in VS Code.

[dbaeumer]

IMO hiding errors from the user is not the right thing to do, since they usually shouldn't happen frequently

@dibarbet if this happens often with the CSharp server you might want to think about handling them special in the middleware of override handleFailedRequest on the client side. I would even considering add something to the client option to have a handler for them. Would this help?

[dibarbet]

@dibarbet if this happens often with the CSharp server you might want to think about handling them special in the middleware of override handleFailedRequest on the client side. I would even considering add something to the client option to have a handler for them. Would this help?

Ah, I can definitely try that. We are planning on fixing the errors on the server side, but it requires some small architectural changes we need to work through. Suppressing them on the client side seems like a good short term workaround. I think (not having tried) that the middleware would probably be good enough, considering it should only be short term.

[dbaeumer]

You should be able to do that in the middleware. If not ping me.