Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a when clause to the contributed explorer view such that it is only activated when the workspace has a java project open #372

Closed
tristan957 opened this issue Nov 6, 2020 · 5 comments · Fixed by #398
Labels
Milestone

Comments

@tristan957
Copy link

The extension contributes its view when I am not in a Java project. I am currently working in a Python project without any Java files. Could you please add a when clause as mentioned in the referenced comment to only show the view contributions when in a Java project?

Context: microsoft/vscode-java-test#793, microsoft/vscode-java-test#793 (comment)

https://github.com/microsoft/vscode-java-dependency/blob/master/package.json#L450

@tristan957
Copy link
Author

Would it also be possible to add a name, contextualTitle, and icon? these would greatly benefit people who move the view into the Activity Bar like myself.

https://code.visualstudio.com/api/references/contribution-points#contributes.views

@jdneo
Copy link
Member

jdneo commented Nov 30, 2020

Would it also be possible to add a name, contextualTitle, and icon?

@tristan957 I created a new issue to track this: #396

@tristan957
Copy link
Author

@jdneo I am still seeing the project explorer in the Activity Bar even when I have no workspace/folder/file open.

image

Is this intended?

@jdneo
Copy link
Member

jdneo commented Dec 16, 2020

Do you mean the button Create Java Project. If that is the case, yes it's intended.

Actually the Java Project explorer is not shown according to your screenshot, we just register a welcome view into the file explorer to provide a shortcut to create a new Java project.

@tristan957
Copy link
Author

Oh really interesting. Thanks for clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants