Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'onDidChangeActiveTextEditor' cannot work for ipynb file #3424

Closed
zesluo opened this issue Feb 26, 2020 · 11 comments
Closed

'onDidChangeActiveTextEditor' cannot work for ipynb file #3424

zesluo opened this issue Feb 26, 2020 · 11 comments
Assignees
Labels
extensibility extension author content under /api support-request

Comments

@zesluo
Copy link

zesluo commented Feb 26, 2020

I'm currently using onDidChangeActiveTextEditor: Event<TextEditor | undefined> to do vscodeextension project. This works for 'py' and 'hql' file. However, if I use ipynb file, this cannot work. I think the main reason for this is that "*.ipynb" file is not a texteditor, so it could not be treated equally. Could you help enhance this api's capability? Thanks in advance!
As shown below, these two are differently treated by the api.
@octref

image
image

@zesluo
Copy link
Author

zesluo commented Feb 26, 2020

or we can enhance the capability of 'TextEditor ' to let it include 'ipynb' file

@gregvanl gregvanl added extensibility extension author content under /api support-request labels Feb 26, 2020
@octref
Copy link
Contributor

octref commented Feb 26, 2020

This is impossible for now. You can ask the Python extension which implemented the ipynb support. You can also wait for the upcoming notebook API: microsoft/vscode#90382.

@octref octref closed this as completed Feb 26, 2020
@zesluo
Copy link
Author

zesluo commented Mar 26, 2020

@octref do we have any plan for updating this API? We currently still need to have this one for supporting our tool. Thank you!

@octref
Copy link
Contributor

octref commented Mar 27, 2020

You should ask @rebornix

@zesluo
Copy link
Author

zesluo commented Mar 28, 2020

thank you @octref. Hi @rebornix, we would like to get some help from you about the api. Thanks in advance!

@zesluo
Copy link
Author

zesluo commented Apr 2, 2020

pinging. @rebornix Thanks

@rebornix
Copy link
Member

rebornix commented Apr 2, 2020

onDidChangeActiveTextEditor will only be emitted when a text editor becomes active, the Notebook Editor in your case is a webview contributed by Python extension, so it's not covered by this event.

@zesluo
Copy link
Author

zesluo commented Apr 7, 2020

Thanks for your reply! Is it possible to convert webview to text editor or apply webview to the API?

@rebornix
Copy link
Member

rebornix commented Apr 7, 2020

@zesluo I don't think so. cc @mjbvz

@zesluo
Copy link
Author

zesluo commented Apr 16, 2020

@rebornix @mjbvz , or any other recommendation? thanks

@zesluo
Copy link
Author

zesluo commented Sep 2, 2020

@rebornix , @mjbvz , is there any suggestion/workaround about it? I think we still need this. Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensibility extension author content under /api support-request
Projects
None yet
Development

No branches or pull requests

4 participants