Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libigl] v2.4.0 broken due to port and upstream problems #30621

Closed
FabienPean opened this issue Apr 2, 2023 · 1 comment · Fixed by #31420
Closed

[libigl] v2.4.0 broken due to port and upstream problems #30621

FabienPean opened this issue Apr 2, 2023 · 1 comment · Fixed by #31420
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@FabienPean
Copy link
Contributor

FabienPean commented Apr 2, 2023

There are numerous issues with the newer version 2.4.0 merged in #26942, most introduced by upstream regressions. While it seemingly "compiles", v2.4.0 is botched. Upstream has been notified libigl/libigl#2186

To Reproduce

Steps to reproduce the behavior:

./vcpkg install libigl

A. Library when using vcpkg with static linkage

Detailed here #30617

B. CMake config files are broken

  1. Naming inconsistent
    image
  2. Main config file not including target file, i.e., missing include(${CMAKE_CURRENT_LIST_DIR}/LibiglConfigTargets.cmake)
  3. It means the include folder of igl cannot be found on a simple test case, because it cannot find the target, making the port basically useless.

C. Features have no effects

Upstream repository does not install the targets containing the options, only the core target, see https://github.com/search?q=repo%3Alibigl%2Flibigl%20igl_install&type=code. Moreover, installing does not include copyleft targets https://github.com/libigl/libigl/blob/a05865e2650f22057fcdc0b77c40d2458922f5d8/CMakeLists.txt#L150. So libigl[cgal] has no effects.

@FabienPean FabienPean added the category:port-bug The issue is with a library, which is something the port should already support label Apr 2, 2023
@FrankXie05
Copy link
Contributor

Fixed by PR #30617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants