-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[arrow] make usable arrow.pc with Windows static builds #29091
Comments
I can't reproduce this issue in my side with the latest vcpkg version 2023-04-07-bedcba5172f5e4b91caac660ab7afe92c27a9895. The contents of my
And below contents run successfully:
|
Here's an example: https://github.com/lukester1975/vcpkg-arrow-pc Link errors:
|
This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 28 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment. |
This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 28 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment. |
Is your feature request related to a problem? Please describe.
This is a follow on from apache/arrow#15139
With vcpkg as of e69dd97 and a
vcpkg.json
:vcpkg install --triplet x64-windows-static-md
from a VS2022 env generatesvcpkg_installed/x64-windows-static-md/debug/lib/pkgconfig/arrow.pc
:This is missing a bunch of the compression libs and as such is not trivially useable. Due to:
Proposed solution
As per apache/arrow#15139, getting
PKG_CONFIG_PATH
passed through to cmake seems to be key. The following hack:generates
arrow.pc
:Which looks correct to me. That's obviously not the right solution (aside from the explicit
debug
) but I have no idea what the correct one is. Trying to setPKG_CONFIG_PATH
explicitly in the environment beforevcpkg install
doesn't work (and would be unpleasant to require even if it did).I do see that
vcpkg_configure_cmake
doesn't usez_vcpkg_setup_pkgconfig_path
at all, whereas the other configures do (vcpkg_configure_qmake
,vcpkg_configure_meson
, etc.). I don't know enough aboutvcpkg
orcmake
to understand if that's intentional or otherwise, however!Happy to try any suggestions but I doubt I'll have any more of my own...
Additional context
Note this apache/arrow#33712 from the arrow issue actually makes the
arrow.pc
worse: apache/arrow#15139 (comment).Thanks
The text was updated successfully, but these errors were encountered: