Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[snappy] generates an invalid snappy.pc #28675

Closed
lukester1975 opened this issue Jan 2, 2023 · 0 comments · Fixed by #28712
Closed

[snappy] generates an invalid snappy.pc #28675

lukester1975 opened this issue Jan 2, 2023 · 0 comments · Fixed by #28712
Assignees
@FrankXie05
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@lukester1975
Copy link

Describe the bug

Library is missing from snappy.pc:

...
Version: 1.1.9
Libs: -L${libdir} -l
Cflags: -I${includedir}

Expected behavior

Libs: -L${libdir} -lsnappy

Additional context

snappy.pc.in is using @libname@ whereas I assume it should be using @name@, since that's what's set in the portfile.

Trivial fix but I can PR it if you want: https://github.com/lukester1975/vcpkg/tree/fix-snappy-pc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankXie05 FrankXie05

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[snappy] fix correct lib name in snappy.pc file FrankXie05/vcpkg
2 participants
@lukester1975 @FrankXie05