Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[binarycaching] cache is not invalidated on update #24748

Closed
redbaron opened this issue May 17, 2022 · 2 comments
Closed

[binarycaching] cache is not invalidated on update #24748

redbaron opened this issue May 17, 2022 · 2 comments
Assignees
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)

Comments

@redbaron
Copy link
Contributor

Describe the bug

when toolchain file include() another file, obtain to the included files doesn't invalidate vcpkg binarycache and doesn't trigger rebuild

Expected behavior
included files are taken into account when calculating toolchain file hash

Additional context

get_toolchain_cache function just hashes the toolchain file content , which ignores any includes. Hashing result of cmake --trace -P toolchain.cmake might give a better result

@Neumann-A
Copy link
Contributor

Known, proposed solution is partly a duplicate of #19984

@Cheney-W Cheney-W self-assigned this May 18, 2022
@Cheney-W Cheney-W added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label May 18, 2022
@Cheney-W
Copy link
Contributor

Thanks for Neumann's reply!
Close this issue as duplicate of #19984.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)
Projects
None yet
Development

No branches or pull requests

3 participants