Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opensubdiv] Provide CMake config #20932

Closed
thomthom opened this issue Oct 22, 2021 · 3 comments
Closed

[opensubdiv] Provide CMake config #20932

thomthom opened this issue Oct 22, 2021 · 3 comments
Assignees
@JonLiu1993
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@thomthom
Copy link

It would be great if the port provided a CMake package config so that the targets in OpenSubdiv was easily available to CMake project via find_package.
@mathisloge
Copy link
Contributor

does normal upstream export a config file?

@thomthom
Copy link
Author

No, it doesn't. The OSD CMake project hasn't been setup to be consumed as a library. I have recently been submitting PRs to allow it to be consumed as a sub project.

@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Oct 25, 2021
@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist and removed category:port-bug The issue is with a library, which is something the port should already support labels Oct 28, 2021
@JackBoosY JackBoosY self-assigned this Oct 28, 2021
@JackBoosY JackBoosY mentioned this issue Oct 28, 2021
Merged
@thomthom thomthom mentioned this issue Apr 27, 2022
Merged
@theblackunknown theblackunknown mentioned this issue Apr 28, 2022
Closed
@theblackunknown theblackunknown mentioned this issue May 8, 2022
Merged
@JonLiu1993
Copy link
Member

Fixed by PR #24615.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thomthom @mathisloge @JackBoosY @JonLiu1993