Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcpkg federation stabilization #15381

Closed
BillyONeal opened this issue Dec 30, 2020 · 5 comments
Closed

vcpkg federation stabilization #15381

BillyONeal opened this issue Dec 30, 2020 · 5 comments
Assignees
@JackBoosY @strega-nil-ms
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed

Comments

@BillyONeal
Copy link
Member

Currently we make concurrent edits to the tool, to scripts, and to the ports tree, but as we do federation, we lose the ability to make such edits. We need to arrive at a solution to allow us to detect problematic behavior, and potentially make improvements to the portfile authoring experience.

This issue contains a list of potential changes we would want to make; we'll revisit this issue when designing whatever system we end up doing.

  • We want to increase the set of banned names (like token.h) because we have evidence those names break customers.
  • We want to make PREFER_NINJA the default for vcpkg_configure_cmake.
  • We want to make vcpkg_test_cmake do something.
@BillyONeal BillyONeal added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist requires:discussion category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed labels Dec 30, 2020
@BillyONeal
Copy link
Member Author

/cc @strega-nil @vicroms @ras0219 @ras0219-msft

@JackBoosY JackBoosY self-assigned this Dec 30, 2020
@Neumann-A
Copy link
Contributor

We want to make PREFER_NINJA the default for vcpkg_configure_cmake.

probably with a global escape hatch like VCPKG_NO_NINJA or defining the cmake generator globally in the triplet.

@JackBoosY
Copy link
Contributor

Related #15173.

@JackBoosY
Copy link
Contributor

JackBoosY commented Jan 8, 2021 •
edited
Loading

We want to make PREFER_NINJA the default for vcpkg_configure_cmake.

Will be resolved in the near future.

@BillyONeal
Copy link
Member Author

@strega-nil did this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JackBoosY JackBoosY

@strega-nil-ms strega-nil-ms

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@BillyONeal @Neumann-A @JackBoosY @strega-nil-ms