Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] TODO: Use pkg-config in vcpkg_fixup_pkgconfig to check for libraries #11103

Closed
Neumann-A opened this issue Apr 30, 2020 · 3 comments · Fixed by #11550
Closed

[vcpkg] TODO: Use pkg-config in vcpkg_fixup_pkgconfig to check for libraries #11103

Neumann-A opened this issue Apr 30, 2020 · 3 comments · Fixed by #11550
Assignees
@strega-nil
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly

Comments

@Neumann-A
Copy link
Contributor

Currently vcpkg_fixup_pkgconfig uses a hand written parser to get the libs used in the *.pc file but this is incomplete and does not always work as intended. As such it is probably better to directly use pkg-config calls to analyse the generated *.pc files for correctness.
@Neumann-A Neumann-A added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Apr 30, 2020
@strega-nil
Copy link
Contributor

Do you want to do this @Neumann-A? I can assign you, if you like.

@Neumann-A Neumann-A mentioned this issue May 24, 2020
Merged
2 tasks
@JackBoosY JackBoosY added category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly and removed category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed labels Jun 12, 2020
@Neumann-A
Copy link
Contributor Author

List available in: #12151 (comment)

@traversaro
Copy link
Contributor

This has been fixed for ffmpeg in #11273, as it was necessary to fix a CI failure of the added port.

@traversaro traversaro mentioned this issue Jul 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@strega-nil strega-nil

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vcpkg/scripts/pkgconfig] rewrite pkg-config check for libraries Neumann-A/vcpkg
4 participants
@traversaro @strega-nil @Neumann-A @JackBoosY