Fix: @typespec/openapi3/invalid-component-fixed-field-key show on incorrect target

[wanlwanl]

Fix: #5832
Result:

[azure-sdk]

All changed packages have been documented.

• ✅ @typespec/openapi3

Show changes

@typespec/openapi3 - fix ✏️

Fix: @typespec/openapi3/invalid-component-fixed-field-key show on incorrect target

[azure-sdk]

You can try these changes here

🛝 Playground	🌐 Website	🛝 VSCode Extension

[wanlwanl]

@timotheeguerin, there's a case I'd like to discuss when new model name could be the same to existing model name:
e.g. suppose we have old model name: foo-/invalid, and existing model name: foo-invalid1, the function to get new model is

const maxRetry = 100000;
const getSuffix = (index) => index;
const getNewName = (name) => { 
  let currentName = name;
  for (let index = 1; alreadyHasSameName(currentName); index++) {
    currentName = name + getsuffix(index);
  }
  return currentName;
}

How much maxRetry is reasonable? Or we don't need it?
I think appending index is enough and no need to append complex random string/guid to avoid conflict, right?

[timotheeguerin]

I don't think we need, feels like an edge case already and probably unlikely you will hit a duplicate if you replace with underscore

[wanlwanl]

@timotheeguerin I udpated this PR, please review it.