issue diagnostic for a templated model with a template parameter that is not used. #5494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunyu3
requested review from
RodgeFu,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
microsoft-github-policy-service
bot
added
the
compiler:core
|
All changed packages have been documented.
|
chunyu3
added
ide
|
You can try these changes here
|
markcowl
reviewed
Jan 9, 2025
| import { createTestHost } from "../../src/testing/test-host.js"; | ||
| import { TestHost } from "../../src/testing/types.js"; | ||
|
|
||
| describe("compiler: unused template parameter in model template", () => { |
There was a problem hiding this comment.
remove top level describe
There was a problem hiding this comment.
hello @timotheeguerin I add more tests to test template parameters in model template, operation template and interface template. Each type of template I create a describe for it to sub-group.
packages/compiler/test/server/unused-template-parameter.test.ts
Outdated
Show resolved
Hide resolved
chunyu3
force-pushed
the
fix181
branch
2 times, most recently
from
66e16cd to
55b8f4f
Compare
…emplate parameters in linter
packages/compiler/test/checker/unused-template-parameter.test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #181
Fix #5488
Fix #5489