Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestAdapter grouping by Traits should not create separate groups for Description and WorkItem attributes #478

Closed
robdalsanto opened this issue Aug 17, 2018 · 4 comments

Comments

@robdalsanto
Copy link

I think the title and the picture illustrate where this can lead. Note also that Owner should not split into different groups. I don't believe this happened prior to MSTest-V2, at least not with WorkItem and Description.

Example of Description attribute:

        [TestMethod, SmokeTypeTest]
        [Description("Bug fix 1506 and 1516. If Alternative linked to Outage then Alternative date has to be updated to selected Outage occurrence date")]
        public void UpdateAlternative_LinkedToOutageTest()
        {

image

@jayaranigarg
Copy link
Member

@robdalsanto : The behaviour has always been like this from adapter side, in both MSTestV1 and MSTestV2.

Tagging @AbhitejJohn @genlu to look into if there has been some behavior difference from test explorer end.

@AbhitejJohn
Copy link
Contributor

This has always been the case based on what the adapter returns as Traits. However, @jfleisher worked on filtering this out earlier, so these do not show up separately in TE. @robdalsanto : What version of VS are you seeing this on?

@robdalsanto
Copy link
Author

@jayaranigarg @AbhitejJohn We are seeing this duplication in VS2015, which occurred immediately after we started to use the NuGet MSTestV2 instead of the MSTestV1 shipped in VS2015.

We don't have a lot of these attributes, and they don't provide much value, like allowing TFS to link to the test-methods from the work-item. So we will likely remove them. Still it is odd to see these 3 attributes as traits.

@singhsarab
Copy link
Contributor

@robdalsanto We identified and fixed the issue. It will be available in the next preview release of the adapter.

@microsoft microsoft locked as resolved and limited conversation to collaborators Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants