Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests not working on the non-English Windows #347

Closed
kant2002 opened this issue Jan 4, 2018 · 3 comments
Closed

Tests not working on the non-English Windows #347

kant2002 opened this issue Jan 4, 2018 · 3 comments

Comments

@kant2002
Copy link
Contributor

kant2002 commented Jan 4, 2018

Description

Running tests does not work when default OS language is non-English. Tests fails since they try to compare English text with Russian output. I try to run tests, to be able finish #299
I have following options which could allow run tests on non-Windows locales

  • Use [AssemblyInitialze] for setting up default locale to be English
  • Maybe rework some code to clearly return errors, instead of relying on the exceptions
  • Change messages to include codes of errors, which would unique identify errors and thus independent of locale. Like MSTEST0001, or if there something like that in place extend list of errors..

Steps to reproduce

  • Take Windows 10 Home Single Language edition which is not English
  • Run build.cmd
  • Run test.cmd

Expected behavior

I expect that all tests would be passed

Actual behavior

Tests which verify text in the output fails.
Example:

Не пройдено:  GetTestMethodInfoShouldThrowIfTestContextHasMultipleAmbiguousTestContextProperties
Сообщение об ошибке:
 StringAssert.StartsWith failed. String 'Unable to find property Microsoft.VisualStudio.TestPlatform.MSTestAdapter.UnitTests.Execution.TypeCacheTests+DummyTestClassWithMultipleTestContextProperties.TestContext. Error:Обнаружено неоднозначное соответствие..' does not start with string 'Unable to find property Microsoft.VisualStudio.TestPlatform.MSTestAdapter.UnitTests.Execution.TypeCacheTests+DummyTestClassWithMultipleTestContextProperties.TestContext. Error:Ambiguous match found..'. .
Трассировка стека:
   в Microsoft.VisualStudio.TestPlatform.MSTestAdapter.UnitTests.Execution.TypeCacheTests.GetTestMethodInfoShouldThrowIfTestContextHasMultipleAmbiguousTestContextProperties() в D:\d\kant\GitHub\tstfx\test\UnitTests\MSTest.CoreAdapter.Unit.Tests\Execution\TypeCacheTests.cs:строка 181

For reference:

Всего тестов: 949. Пройдено: 904. Не пройдено: 39. Пропущено: 6.

with translation

Total tests: 949. Passed: 904. Failed: 39. Skipped: 6.

Environment

  • Windows 10 Home Single Language (Russian)
@kant2002
Copy link
Contributor Author

kant2002 commented Jan 4, 2018

The underlying cause for that is command

xcopy /Y /I /S /E ..\..\..\packages\MSTest.Internal.TestFx.Localized.Documentation.1.0.0-build-20170420-1\contentFiles\any\any\Extensions\Desktop ..\..\..\artifacts\Debug\Extension.Desktop\

which seems to be does not respect MAX_PATH relaxation in the registry.

@jayaranigarg
Copy link
Member

We currently don't have the infra for this in place. Closing the issue for now.
We would be more than happy if you would want to contribute this.

@kant2002
Copy link
Contributor Author

kant2002 commented Feb 2, 2018

@jayaranigarg Please reopen, since I do want to contribute and you really does not give me any time to respond

singhsarab pushed a commit to singhsarab/testfx that referenced this issue Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants