Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ClassCleanup default behavior to be "EndOfClass" #1316

Open
Evangelink opened this issue Oct 8, 2022 · 1 comment · Fixed by #1538
Open

Change ClassCleanup default behavior to be "EndOfClass" #1316

Evangelink opened this issue Oct 8, 2022 · 1 comment · Fixed by #1538
Assignees
@engyebrahim
Labels
Breaking ‼️
Milestone
4.0.0

Comments

@Evangelink
Copy link
Member

Evangelink commented Oct 8, 2022 •
edited by testplatform-bot
Loading

Summary

Current behavior of ClassCleanupAttribute is to be run at the end of the assembly and not at the end of the class as the name would suggest.

Note that it is possible to change this behavior (locally with a ctor/property) or globally using ClassCleanupExecutionAttribute.

Proposed Enhancement

Change default behavior to be EndOfClass. Although this is a breaking change, it will be possible for users to revert to old behavior simply by adding [assembly: ClassCleanupExecution(ClassCleanupBehavior.EndOfAssembly)].

AB#1711729
@Evangelink Evangelink mentioned this issue Oct 8, 2022
Open
24 tasks
@Evangelink Evangelink added this to the 4.0.0 milestone Oct 8, 2022
@Evangelink Evangelink changed the title ClassCleanup default behavior should be "EndOfClass" Change ClassCleanup default behavior to be "EndOfClass" Nov 11, 2022
@Evangelink Evangelink mentioned this issue Nov 23, 2022
Closed
@engyebrahim engyebrahim mentioned this issue Jan 6, 2023
Merged
@ghost ghost added the State: In-PR label Jan 6, 2023
Evangelink pushed a commit that referenced this issue Jan 10, 2023
@engyebrahim
Change ClassCleanup default behavior to be "EndOfClass" (#1538)
2d2ab81 
fix #1316
@ghost ghost added Resolution: Fixed and removed State: In-PR labels Jan 10, 2023
@Evangelink Evangelink mentioned this issue Feb 2, 2023
Open
@pavelhorak pavelhorak removed the sprint label Oct 2, 2023
@Youssef1313
Copy link
Member

@Evangelink I'm re-opening as the PR that closed this issue was reverted

@Youssef1313 Youssef1313 reopened this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engyebrahim engyebrahim

Labels
Breaking ‼️
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Change ClassCleanup default behavior to be "EndOfClass" engyebrahim/testfx
4 participants
@Evangelink @pavelhorak @engyebrahim @Youssef1313