Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomTextRenderer::_DrawGlowGlyphRun text is (sometimes) bold and smeared looking. #621

Closed
JamesG269 opened this issue May 9, 2019 · 8 comments
Assignees
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.

Comments

@JamesG269
Copy link

Microsoft Windows [Version 10.0.18362.86]

Issue: Text rendering for CustomTextRenderer::_DrawGlowGlyphRun seems off.
I did the exact modifications as the dev (Mike) at the build conference to enable glowing text, which required uncommenting the line to call the function (and commenting the default text render call). I'm sorry if this is out of the scope of this issue tracker since it is not the default code, but I thought it should be included as glowing text makes the blurred background many times more usable, and well it seems off on my system.
The first image is the dev's system from the video on top and mine right beneath it, the second image is when I modified the function to draw random colors, to demonstrate that some colors are off (they look bolded and blurred) and others seem correct. Ideally I'm certain all of the colors should look something like Mike's did. I realize Mike was running regular conhost, but even in my pure open terminal window, you can see for instance the WinStore.App looks much better than most the others.

terminal-text
terminal-text2

@zadjii-msft
Copy link
Member

This is probably part of the reason why we haven't enabled it as an official setting yet :P

If anyone in the community wants to help polish the glowtext mode, I'd be happy to wire a setting up to it.

@miniksa for visibility

@zadjii-msft zadjii-msft added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Help Wanted We encourage anyone to jump in on these. labels May 9, 2019
@Nacimota
Copy link
Contributor

Nacimota commented May 9, 2019

It's hard to tell from those screenshots, but it doesn't look like it's broken to me. It just looks like the lighter colours seem to have the effect of adding weight to a similarly light text colour, which makes sense.

@JamesG269
Copy link
Author

@Nacimota But shouldn't the first screen's text be identical to the video capped one from the build conference demo (First pic, mine is below a screen shot from the build demo?)

@Nacimota
Copy link
Contributor

Nacimota commented May 9, 2019

Well possibly, if the code is identical. The red does look darker to me in the video though, and the font size is definitely larger which could make the glow effect present slightly differently. 🤷‍♂️

@JamesG269
Copy link
Author

JamesG269 commented May 9, 2019

I think it's both of those things, but mostly the relation of darkness to brightness in the brush vs. the outline. I limited each of the RGB values to 0-128 in the outlinebrush, instead of 0-256:
Untitled
Looks good, please include this as an option.

@miniksa
Copy link
Member

miniksa commented May 9, 2019

Please don't get too far on this one. I have some internal discussions that I had prior to Build on how to do glow text better than this sample. The folks who briefed me had great justifications on why this way of doing glow was not optimal, but I'll dig them up in the next week or so and get back to this.

@miniksa miniksa self-assigned this May 9, 2019
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added Product-Terminal The new Windows Terminal. and removed Mass-Chaos labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@Psychlist1972
Copy link

I'd love to see glow working, so I can get that lovely classic monochrome VT terminal or color CRT aesthetic.

@zadjii-msft
Copy link
Member

You know, with custom shaders (#7013), I don't think we really need to re-explore this. Let's just let folks do their own shader thing, that's been pretty dang flexible so far.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

5 participants