Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option: Adjust lightness of indistinguishable text #6121

Closed
hectormz opened this issue May 22, 2020 · 4 comments
Closed

Add option: Adjust lightness of indistinguishable text #6121

hectormz opened this issue May 22, 2020 · 4 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@hectormz
Copy link

Description of the new feature/enhancement

ConEmu has an option to:

‘Adjust lightness of indistinguishable text’ on the ‘Colors’ settings page. The idea is to make text readable if certain foreground and background colors are indistinguishable for current palette. ConEmu will try to change the lightness of the foreground text.

This is useful when two light colors are displayed with each other. Here is an example using Solarized Git color scheme with the feature off:

image

and with it on:

image

Proposed technical implementation details (optional)

It would be great to have a similar flag to set as an option in settings.json

ConEmu's method could be an inspiration. Here is the commit that added it.
@hectormz hectormz added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 22, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 22, 2020
@DHowett
Copy link
Member

DHowett commented May 22, 2020

Thanks for the request! This is tracked at /dup #2368 (which is also inspired by the ConEmu feature!)

@ghost
Copy link

ghost commented May 22, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed May 22, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 22, 2020
@DHowett
Copy link
Member

DHowett commented May 22, 2020

I'm sorry, I meant #2638.

@hectormz
Copy link
Author

Awesome, I didn't quite find it. I'll check out that issue!

@DHowett DHowett mentioned this issue Jun 26, 2020
Closed
@zadjii-msft zadjii-msft mentioned this issue Jul 6, 2020
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DHowett @hectormz