Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress ring is clipped when tab title is too long #10584

Closed
j4james opened this issue Jul 8, 2021 · 5 comments
Closed

Progress ring is clipped when tab title is too long #10584

j4james opened this issue Jul 8, 2021 · 5 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@j4james
Copy link
Collaborator

j4james commented Jul 8, 2021

Windows Terminal version (or Windows build number)

10.0.18363.1500, 1.9.1523.0

Other Software

No response

Steps to reproduce

  1. Open a cmd shell in Windows Terminal.
  2. Set the title to something too long to fit in the tab, e.g. title This is a long title that doesn't fit.
  3. Set the progress indicator, e.g. echo ^[]9;4;1;100^[\ (where ^[ is entered as Ctrl+[).

Expected Behavior

You should see a full progress ring in the tab indicating 100%.

Actual Behavior

The left half of the progress ring is chopped off, so it looks like it's only at 50%.

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 8, 2021
@skyline75489
Copy link
Collaborator

Thanks James for the report! We have #8910 for this.

@zadjii-msft
Copy link
Member

/dup #8910

@ghost
Copy link

ghost commented Jul 8, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jul 8, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 8, 2021
@j4james
Copy link
Collaborator Author

j4james commented Jul 8, 2021

Sorry, I'm blind as a bat. I looked at all the followup issues in #6700 and somehow completely missed #8910.

@zadjii-msft
Copy link
Member

lol don't worry about it. Thanks for the detailed report regardless!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@j4james @skyline75489 @zadjii-msft