Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E test TreeDump utility update to fire event when comparison succeed #3779

Closed
ddalp opened this issue Dec 16, 2019 · 2 comments
Closed

E2E test TreeDump utility update to fire event when comparison succeed #3779

ddalp opened this issue Dec 16, 2019 · 2 comments
Assignees
@kmelmon
Labels
Area: Test Infrastructure nice-to-have p3
Milestone
Backlog

Comments

@ddalp
Copy link
Contributor

ddalp commented Dec 16, 2019

This is low priority test infra enhancement issue:

Currently we are polling on the test tree dump comparison result (getTreeDumpResult in BasePage.ts), we should be firing event when layout tree dump comprison pass. Currently the custom view manager fails in release mode because constructor with the Context object is optimized away, we need Context object to fire event from custom view manager.
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Dec 16, 2019
@ddalp ddalp mentioned this issue Dec 16, 2019
Merged
@ddalp ddalp closed this as completed Dec 16, 2019
@ddalp ddalp reopened this Dec 16, 2019
@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jan 6, 2020
@chrisglein chrisglein added this to the MVP+ (vNext M5) milestone Jan 6, 2020
@chrisglein chrisglein removed the vnext label Mar 18, 2020
@asklar asklar self-assigned this Apr 21, 2020
@chrisglein chrisglein modified the milestones: 0.63, Backlog Jul 13, 2020
@asklar
Copy link
Member

asklar commented Aug 11, 2020

moving to you @kmelmon since you're looking at e2etests now

@asklar asklar removed their assignment Aug 12, 2020
@asklar asklar mentioned this issue Aug 26, 2020
Closed
@kmelmon
Copy link
Contributor

kmelmon commented Aug 26, 2020

This will be superseded by #5841.

@kmelmon kmelmon closed this as completed Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmelmon kmelmon

Labels
Area: Test Infrastructure nice-to-have p3
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@asklar @chrisglein @ddalp @kmelmon