Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to toggle JS debugging from Developer Menu with ReactApplication #3610

Closed
jonthysell opened this issue Nov 6, 2019 · 3 comments
Closed

Unable to toggle JS debugging from Developer Menu with ReactApplication #3610

jonthysell opened this issue Nov 6, 2019 · 3 comments
Assignees
@ddalp
Labels
Area: Developer Menu bug must-have p1
Milestone
MVP (vNext M4)

Comments

@jonthysell
Copy link
Contributor

Clicking the button refreshes the app, but does not toggle the state. Repros in SampleApps, and new CLI apps.
@jonthysell jonthysell self-assigned this Nov 6, 2019
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 6, 2019
@jonthysell jonthysell added this to the MVP (vNext M4) milestone Nov 6, 2019
@chrisglein
Copy link
Member

Regression from the ReactApplication change?

@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 11, 2019
@jonthysell
Copy link
Contributor Author

Regression from the ReactApplication change?

Probably, but shouldn't need to be me to fix it.

@jonthysell jonthysell removed their assignment Nov 11, 2019
@ddalp ddalp mentioned this issue Dec 12, 2019
Merged
@ddalp
Copy link
Contributor

ddalp commented Dec 13, 2019

Fixed.

@ddalp ddalp closed this as completed Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddalp ddalp

Labels
Area: Developer Menu bug must-have p1
Projects
None yet
Milestone
MVP (vNext M4)
Development

No branches or pull requests
3 participants
@jonthysell @chrisglein @ddalp