Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running RNWCPP on RS2 #2366

Closed
kmelmon opened this issue Apr 29, 2019 · 2 comments
Closed

Add support for running RNWCPP on RS2 #2366

kmelmon opened this issue Apr 29, 2019 · 2 comments
Assignees

Comments

@kmelmon
Copy link
Contributor

kmelmon commented Apr 29, 2019

Currently RNWCPP targets RS3 as a min target. This issue is tracking making RS2 the minimum supported platform. Reason: To support SurfaceHub, which is currently running RS2.

A few things are required:
-Change the VS solutions: set min platform version to RS2
-Andy says: We have the version numbers in react.cpp.props for SDK target versions.  We should be able to set it back to RS2, I don't think those settings actually do much with cppwinrt includes anyway
-Ensure we aren't calling any WinRT APIs that don't exist on RS2. Andy says:
There are 2 things that check SDK version right now: if you search for ApiInformation::IsPropertyPresent its TextDecortations to support underline/strikethrough text requires RS2, editable ComboBox in Picker lights up with RS5. 
What we could do is temporarily change the target version to RS2 and the compiler will find any other APIs that didn't exist then.
-Change build pipeline(s) to install the RS2 SDK.
-Update readme (RS2 SDK is required instead of RS3)

@kmelmon kmelmon added the rnwcpp label Apr 29, 2019
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Apr 29, 2019
@ahimberg
Copy link
Member

We build with the latest public SDK (so we can reference new features, and use latest cppwinrt), but tell it to target the min version we're supporting. So the next to last point (install rs2 sdk) probably isn't needed.

@kmelmon kmelmon added ready for dev and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels May 1, 2019
@kmelmon kmelmon added this to the RNWCPP Milestone 2 milestone May 1, 2019
@licanhua
Copy link
Contributor

tests will be tracked by other test task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants