From 09b23967bcb4276530a2cbb495ab10dce5909276 Mon Sep 17 00:00:00 2001
From: tudorms <48035227+tudorms@users.noreply.github.com>
Date: Wed, 15 May 2019 09:18:03 -0700
Subject: [PATCH] Add v8runtime export to the def file and a dummy
 implementation for GitHub (#2472)

---
 vnext/Desktop.DLL/react-native-win32.x64.def |  1 +
 vnext/Desktop.DLL/react-native-win32.x86.def |  1 +
 vnext/ReactCommon/ReactCommon.vcxproj        |  1 +
 vnext/ReactCommon/nov8.cpp                   | 14 ++++++++++++++
 4 files changed, 17 insertions(+)
 create mode 100644 vnext/ReactCommon/nov8.cpp

diff --git a/vnext/Desktop.DLL/react-native-win32.x64.def b/vnext/Desktop.DLL/react-native-win32.x64.def
index 6fa74d56ac5..2e1596ab941 100644
--- a/vnext/Desktop.DLL/react-native-win32.x64.def
+++ b/vnext/Desktop.DLL/react-native-win32.x64.def
@@ -54,6 +54,7 @@ EXPORTS
 ??1Value@jsi@facebook@@QEAA@XZ
 ??1Buffer@jsi@facebook@@UEAA@XZ
 ?makeChakraJsiRuntime@chakraruntime@jsi@facebook@@YA?AV?$unique_ptr@VRuntime@jsi@facebook@@U?$default_delete@VRuntime@jsi@facebook@@@std@@@std@@$$QEAUChakraJsiRuntimeArgs@123@@Z
+?makeV8Runtime@v8runtime@facebook@@YA?AV?$unique_ptr@VRuntime@jsi@facebook@@U?$default_delete@VRuntime@jsi@facebook@@@std@@@std@@XZ
 
 
 YGNodeNew
diff --git a/vnext/Desktop.DLL/react-native-win32.x86.def b/vnext/Desktop.DLL/react-native-win32.x86.def
index 28248f1bffb..0248307777b 100644
--- a/vnext/Desktop.DLL/react-native-win32.x86.def
+++ b/vnext/Desktop.DLL/react-native-win32.x86.def
@@ -54,6 +54,7 @@ EXPORTS
 ??1Value@jsi@facebook@@QAE@XZ
 ??1Buffer@jsi@facebook@@UAE@XZ
 ?makeChakraJsiRuntime@chakraruntime@jsi@facebook@@YG?AV?$unique_ptr@VRuntime@jsi@facebook@@U?$default_delete@VRuntime@jsi@facebook@@@std@@@std@@$$QAUChakraJsiRuntimeArgs@123@@Z
+?makeV8Runtime@v8runtime@facebook@@YG?AV?$unique_ptr@VRuntime@jsi@facebook@@U?$default_delete@VRuntime@jsi@facebook@@@std@@@std@@XZ
 
 
 YGLog
diff --git a/vnext/ReactCommon/ReactCommon.vcxproj b/vnext/ReactCommon/ReactCommon.vcxproj
index 9266673be9c..a9568de2a35 100644
--- a/vnext/ReactCommon/ReactCommon.vcxproj
+++ b/vnext/ReactCommon/ReactCommon.vcxproj
@@ -184,6 +184,7 @@
     <ClCompile Include="$(ReactNativeDir)\ReactCommon\jsi\V8Platform.cpp"  Condition="'$(Platform)' != 'arm' AND '$(USE_V8)' == 'true'"/>
     <ClCompile Include="$(ReactNativeDir)\ReactCommon\jsi\V8Runtime_shared.cpp"  Condition="'$(Platform)' != 'arm' AND '$(USE_V8)' == 'true'"/>
     <ClCompile Include="$(ReactNativeDir)\ReactCommon\jsi\V8Runtime_win.cpp"  Condition="'$(Platform)' != 'arm' AND '$(USE_V8)' == 'true'"/>
+    <ClCompile Include="nov8.cpp" Condition="'$(Platform)' != 'arm' AND '$(USE_V8)' != 'true'"/>
     <ClCompile Include="$(YogaDir)\yoga\Utils.cpp" />
     <ClCompile Include="$(YogaDir)\yoga\YGConfig.cpp" />
     <ClCompile Include="$(YogaDir)\yoga\YGEnums.cpp" />
diff --git a/vnext/ReactCommon/nov8.cpp b/vnext/ReactCommon/nov8.cpp
new file mode 100644
index 00000000000..f93a6db60e1
--- /dev/null
+++ b/vnext/ReactCommon/nov8.cpp
@@ -0,0 +1,14 @@
+#include <memory>
+#include <jsi/jsi.h>
+
+namespace facebook {
+namespace v8runtime {
+
+// This exists just to satisfy the export requirements, so that we can share the same .def file between GitHub and the Office internal build system
+std::unique_ptr<jsi::Runtime> makeV8Runtime()
+{
+  std::abort();
+}
+
+} // namespace v8runtime
+} // namespace facebook