Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] text= selector does not match case-insensitive by default #1120

Closed
aesyondu opened this issue Feb 26, 2020 · 0 comments · Fixed by #1151
Closed

[Question] text= selector does not match case-insensitive by default #1120

aesyondu opened this issue Feb 26, 2020 · 0 comments · Fixed by #1151
Assignees

Comments

@aesyondu
Copy link
Contributor

aesyondu commented Feb 26, 2020

According to selectors.md:

By default, the match is case-insensitive, and ignores leading/trailing whitespace. This means text= Login matches <button>loGIN </button>.

However, I noticed in my test this is not the case. I tried to dig a little and found out in the queryselector.spec tests that in order to match case-insensitive, one needs to create a RegExp-like text selector: text=/My Selector/i. This is the commit that illustrates it: aesyondu@a51dc8b

Should the docs be changed, since matching is case-sensitive?

@aesyondu aesyondu changed the title [Question] text= selector does not matching case-insensitive by default [Question] text= selector does not match case-insensitive by default Feb 26, 2020
@dgozman dgozman self-assigned this Feb 27, 2020
@dgozman dgozman added the v1 label Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants