Skip to content

Commit ce3398b

Browse files
authored
browser(webkit): allow scripts in inspected pages to create popups (#1192)
1 parent a3ed301 commit ce3398b

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

browser_patches/webkit/BUILD_NUMBER

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1162
1+
1164

browser_patches/webkit/patches/bootstrap.diff

+6-2
Original file line numberDiff line numberDiff line change
@@ -7287,7 +7287,7 @@ index a2239cec8e18850f35f7f88a9c4ebadc62bf4023..79f3ff84327dc075ec96983e04db4b10
72877287

72887288
} // namespace WebKit
72897289
diff --git a/Source/WebKit/UIProcess/Inspector/WebPageInspectorController.cpp b/Source/WebKit/UIProcess/Inspector/WebPageInspectorController.cpp
7290-
index 1ee28bf716374371433215148aa20a51927a8a33..4441b7ca96e4ec349609c8be06a69ea53c55f4ce 100644
7290+
index 1ee28bf716374371433215148aa20a51927a8a33..a41732eb550bc4079ae14d2cbd2c3b082e1fda73 100644
72917291
--- a/Source/WebKit/UIProcess/Inspector/WebPageInspectorController.cpp
72927292
+++ b/Source/WebKit/UIProcess/Inspector/WebPageInspectorController.cpp
72937293
@@ -26,10 +26,16 @@
@@ -7559,7 +7559,7 @@ index 1ee28bf716374371433215148aa20a51927a8a33..4441b7ca96e4ec349609c8be06a69ea5
75597559
}
75607560

75617561
void WebPageInspectorController::willDestroyProvisionalPage(const ProvisionalPageProxy& provisionalPage)
7562-
@@ -218,4 +389,16 @@ void WebPageInspectorController::addTarget(std::unique_ptr<InspectorTargetProxy>
7562+
@@ -218,4 +389,20 @@ void WebPageInspectorController::addTarget(std::unique_ptr<InspectorTargetProxy>
75637563
m_targets.set(target->identifier(), WTFMove(target));
75647564
}
75657565

@@ -7573,6 +7573,10 @@ index 1ee28bf716374371433215148aa20a51927a8a33..4441b7ca96e4ec349609c8be06a69ea5
75737573
+ // Navigation to cached pages doesn't fire some of the events (e.g. execution context created)
75747574
+ // that inspector depends on. So we disable the cache when front-end connects.
75757575
+ m_page.preferences().setUsesBackForwardCache(false);
7576+
+
7577+
+ // Enable popup debugging.
7578+
+ // TODO: allow to set preferences over the inspector protocol or find a better place for this.
7579+
+ m_page.preferences().setJavaScriptCanOpenWindowsAutomatically(true);
75767580
+}
75777581
+
75787582
} // namespace WebKit

0 commit comments

Comments
 (0)