From bf25a936175765c89bf9e0e241c0816995e6e025 Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Fri, 19 May 2023 15:20:42 -0700 Subject: [PATCH] cherry-pick(#23171): fix(tracing): when zipping remotely, use correct file name (#23173) Fixes #23108. --- packages/playwright-core/src/server/trace/recorder/tracing.ts | 2 +- tests/library/tracing.spec.ts | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/playwright-core/src/server/trace/recorder/tracing.ts b/packages/playwright-core/src/server/trace/recorder/tracing.ts index 6ac2cd5be00e6..4ce912f79d581 100644 --- a/packages/playwright-core/src/server/trace/recorder/tracing.ts +++ b/packages/playwright-core/src/server/trace/recorder/tracing.ts @@ -324,7 +324,7 @@ export class Tracing extends SdkObject implements InstrumentationListener, Snaps for (const entry of entries) zipFile.addFile(entry.value, entry.name); zipFile.end(); - const zipFileName = state.traceFile + '.zip'; + const zipFileName = state.traceFile.file + '.zip'; zipFile.outputStream.pipe(fs.createWriteStream(zipFileName)).on('close', () => { const artifact = new Artifact(this._context, zipFileName); artifact.reportFinished(); diff --git a/tests/library/tracing.spec.ts b/tests/library/tracing.spec.ts index 0068de5f437fb..6c125da67c392 100644 --- a/tests/library/tracing.spec.ts +++ b/tests/library/tracing.spec.ts @@ -578,7 +578,6 @@ test('should record global request trace', async ({ request, context, server }, }); test('should store global request traces separately', async ({ request, server, playwright, browserName, mode }, testInfo) => { - test.fixme(browserName === 'chromium' && mode === 'driver', 'https://github.com/microsoft/playwright/issues/23108'); const request2 = await playwright.request.newContext(); await Promise.all([ (request as any)._tracing.start({ snapshots: true }),