From a96dec58c830210625b35729ba23f48fbc363df4 Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Fri, 13 Mar 2020 14:43:49 -0700 Subject: [PATCH] fix(webkit): emit close on pages before clearing them (#1386) --- src/webkit/wkBrowser.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/webkit/wkBrowser.ts b/src/webkit/wkBrowser.ts index 8569066570358..59a700a4cafc8 100644 --- a/src/webkit/wkBrowser.ts +++ b/src/webkit/wkBrowser.ts @@ -68,9 +68,10 @@ export class WKBrowser extends platform.EventEmitter implements Browser { _onDisconnect() { for (const wkPage of this._wkPages.values()) wkPage.dispose(); - this._wkPages.clear(); for (const context of this._contexts.values()) context._browserClosed(); + // Note: previous method uses pages to issue 'close' event on them, so we clear them after. + this._wkPages.clear(); this.emit(Events.Browser.Disconnected); }