Skip to content

Commit 857ffd8

Browse files
fix: text selector should be case insensitive without quotes (#1151)
1 parent de542c0 commit 857ffd8

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

src/injected/textSelectorEngine.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,6 @@ function createMatcher(selector: string): Matcher {
8080
const re = new RegExp(selector.substring(1, lastSlash), selector.substring(lastSlash + 1));
8181
return text => re.test(text);
8282
}
83-
selector = selector.trim();
84-
return text => text.trim() === selector;
83+
selector = selector.trim().toLowerCase();
84+
return text => text.trim().toLowerCase() === selector;
8585
}

test/queryselector.spec.js

+5
Original file line numberDiff line numberDiff line change
@@ -523,6 +523,11 @@ module.exports.describe = function({testRunner, expect, selectors, FFOX, CHROMIU
523523
await page.setContent(`<div> "yo <div></div>ya</div>`);
524524
expect(await selectors._createSelector('text', await page.$('div'))).toBe('" \\"yo "');
525525
});
526+
it('should be case sensitive iff quotes are sepcified', async({page}) => {
527+
await page.setContent(`<div>yo</div><div>ya</div><div>\nye </div>`);
528+
expect(await page.$eval(`text=yA`, e => e.outerHTML)).toBe('<div>ya</div>');
529+
expect(await page.$(`text="yA"`)).toBe(null);
530+
});
526531
});
527532

528533
describe('selectors.register', () => {

0 commit comments

Comments
 (0)