Skip to content

Commit 6b6a671

Browse files
authored
fix(webkit): pass popup tests (#1138)
1 parent d41342f commit 6b6a671

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"playwright": {
1111
"chromium_revision": "744254",
1212
"firefox_revision": "1031",
13-
"webkit_revision": "1159"
13+
"webkit_revision": "1162"
1414
},
1515
"scripts": {
1616
"ctest": "cross-env BROWSER=chromium node test/test.js",

test/popup.spec.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
2020
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
2121

2222
describe('window.open', function() {
23-
it.skip(CHROMIUM || WEBKIT)('should inherit user agent from browser context', async function({browser, server}) {
23+
it.skip(CHROMIUM)('should inherit user agent from browser context', async function({browser, server}) {
2424
const context = await browser.newContext({
2525
userAgent: 'hey'
2626
});
@@ -61,9 +61,9 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
6161
await context.close();
6262
expect(hasTouch).toBe(true);
6363
});
64-
it.skip(CHROMIUM || WEBKIT)('should inherit viewport size from browser context', async function({browser, server}) {
64+
it.skip(CHROMIUM)('should inherit viewport size from browser context', async function({browser, server}) {
6565
const context = await browser.newContext({
66-
viewport: { width: 400, height: 500, isMobile: true }
66+
viewport: { width: 400, height: 500 }
6767
});
6868
const page = await context.newPage();
6969
await page.goto(server.EMPTY_PAGE);

0 commit comments

Comments
 (0)