Skip to content

Commit 5bd6e49

Browse files
pavelfeldmanpavelfeldman
authored
test: it.skip skips and it.fail expects to fail now (#1178)
1 parent 08fbc92 commit 5bd6e49

22 files changed

+62
-58
lines changed

‎test/accessibility.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT,
8585
};
8686
expect(await page.accessibility.snapshot()).toEqual(golden);
8787
});
88-
it.skip(WEBKIT && !MAC)('should work with regular text', async({page}) => {
88+
it.fail(WEBKIT && !MAC)('should work with regular text', async({page}) => {
8989
await page.setContent(`<div>Hello World</div>`);
9090
const snapshot = await page.accessibility.snapshot();
9191
expect(snapshot.children[0]).toEqual({

‎test/capabilities.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ module.exports.describe = function({testRunner, expect, WIN, WEBKIT}) {
2626
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
2727

2828
describe('Capabilities', function() {
29-
it.skip(WEBKIT && WIN)('Web Assembly should work', async function({page, server}) {
29+
it.fail(WEBKIT && WIN)('Web Assembly should work', async function({page, server}) {
3030
await page.goto(server.PREFIX + '/wasm/table2.html');
3131
expect(await page.evaluate(() => loadTable())).toBe('42, 83');
3232
});

‎test/chromium/pdf.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ module.exports.describe = function({testRunner, expect, headless, ASSETS_DIR}) {
2626
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
2727

2828
// Printing to pdf is currently only supported in headless
29-
describe.skip(!headless)('Page.pdf', function() {
29+
describe.fail(!headless)('Page.pdf', function() {
3030
it('should be able to save file', async({page, server}) => {
3131
const outputFile = path.join(ASSETS_DIR, 'output.pdf');
3232
await page.pdf({path: outputFile});

‎test/click.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMI
326326
expect(await page.evaluate(() => offsetX)).toBe(WEBKIT ? 12 * 2 + 20 : 20);
327327
expect(await page.evaluate(() => offsetY)).toBe(WEBKIT ? 12 * 2 + 10 : 10);
328328
});
329-
it.skip(FFOX)('should click a very large button with offset', async({page, server}) => {
329+
it.fail(FFOX)('should click a very large button with offset', async({page, server}) => {
330330
await page.goto(server.PREFIX + '/input/button.html');
331331
await page.$eval('button', button => button.style.borderWidth = '8px');
332332
await page.$eval('button', button => button.style.height = button.style.width = '2000px');
@@ -336,7 +336,7 @@ module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMI
336336
expect(await page.evaluate(() => offsetX)).toBe(WEBKIT ? 1900 + 8 : 1900);
337337
expect(await page.evaluate(() => offsetY)).toBe(WEBKIT ? 1910 + 8 : 1910);
338338
});
339-
it.skip(FFOX)('should click a button in scrolling container with offset', async({page, server}) => {
339+
it.fail(FFOX)('should click a button in scrolling container with offset', async({page, server}) => {
340340
await page.goto(server.PREFIX + '/input/button.html');
341341
await page.$eval('button', button => {
342342
const container = document.createElement('div');

‎test/cookies.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ module.exports.describe = function({testRunner, expect, playwright, defaultBrows
5454
expect(cookies.length).toBe(1);
5555
expect(cookies[0].httpOnly).toBe(true);
5656
});
57-
it.skip(WEBKIT && !MAC)('should properly report "Strict" sameSite cookie', async({context, page, server}) => {
57+
it.fail(WEBKIT && !MAC)('should properly report "Strict" sameSite cookie', async({context, page, server}) => {
5858
server.setRoute('/empty.html', (req, res) => {
5959
res.setHeader('Set-Cookie', 'name=value;SameSite=Strict');
6060
res.end();
@@ -64,7 +64,7 @@ module.exports.describe = function({testRunner, expect, playwright, defaultBrows
6464
expect(cookies.length).toBe(1);
6565
expect(cookies[0].sameSite).toBe('Strict');
6666
});
67-
it.skip(WEBKIT && !MAC)('should properly report "Lax" sameSite cookie', async({context, page, server}) => {
67+
it.fail(WEBKIT && !MAC)('should properly report "Lax" sameSite cookie', async({context, page, server}) => {
6868
server.setRoute('/empty.html', (req, res) => {
6969
res.setHeader('Set-Cookie', 'name=value;SameSite=Lax');
7070
res.end();

‎test/elementhandle.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT})
299299
});
300300

301301
describe('ElementHandle.scrollIntoViewIfNeeded', function() {
302-
it.skip(FFOX)('should work', async({page, server}) => {
302+
it.fail(FFOX)('should work', async({page, server}) => {
303303
await page.goto(server.PREFIX + '/offscreenbuttons.html');
304304
for (let i = 0; i < 11; ++i) {
305305
const button = await page.$('#btn' + i);

‎test/emulation.spec.js

+8-8
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF
8989
expect(await page.evaluate(() => Modernizr.touchevents)).toBe(true);
9090
await context.close();
9191
});
92-
it.skip(FFOX)('should support landscape emulation', async({browser, server}) => {
92+
it.fail(FFOX)('should support landscape emulation', async({browser, server}) => {
9393
const context1 = await browser.newContext({ viewport: iPhone.viewport });
9494
const page1 = await context1.newPage();
9595
await page1.goto(server.PREFIX + '/mobile.html');
@@ -100,7 +100,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF
100100
await context1.close();
101101
await context2.close();
102102
});
103-
it.skip(FFOX || WEBKIT)('should fire orientationchange event', async({browser, server}) => {
103+
it.fail(FFOX || WEBKIT)('should fire orientationchange event', async({browser, server}) => {
104104
const context = await browser.newContext({ viewport: { width: 300, height: 400, isMobile: true } });
105105
const page = await context.newPage();
106106
await page.goto(server.PREFIX + '/mobile.html');
@@ -118,14 +118,14 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF
118118
expect((await event2).text()).toBe('2');
119119
await context.close();
120120
});
121-
it.skip(FFOX)('default mobile viewports to 980 width', async({browser, server}) => {
121+
it.fail(FFOX)('default mobile viewports to 980 width', async({browser, server}) => {
122122
const context = await browser.newContext({ viewport: {width: 320, height: 480, isMobile: true} });
123123
const page = await context.newPage();
124124
await page.goto(server.PREFIX + '/empty.html');
125125
expect(await page.evaluate(() => window.innerWidth)).toBe(980);
126126
await context.close();
127127
});
128-
it.skip(FFOX)('respect meta viewport tag', async({browser, server}) => {
128+
it.fail(FFOX)('respect meta viewport tag', async({browser, server}) => {
129129
const context = await browser.newContext({ viewport: {width: 320, height: 480, isMobile: true} });
130130
const page = await context.newPage();
131131
await page.goto(server.PREFIX + '/mobile.html');
@@ -199,7 +199,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF
199199
await page.emulateMedia({ colorScheme: 'bad' }).catch(e => error = e);
200200
expect(error.message).toBe('Unsupported color scheme: bad');
201201
});
202-
it.skip(FFOX)('should work during navigation', async({page, server}) => {
202+
it.fail(FFOX)('should work during navigation', async({page, server}) => {
203203
await page.emulateMedia({ colorScheme: 'light' });
204204
const navigated = page.goto(server.EMPTY_PAGE);
205205
for (let i = 0; i < 9; i++) {
@@ -213,7 +213,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF
213213
});
214214
});
215215

216-
describe.skip(FFOX)('BrowserContext({timezoneId})', function() {
216+
describe.fail(FFOX)('BrowserContext({timezoneId})', function() {
217217
it('should work', async ({ browser }) => {
218218
const func = () => new Date(1479579154987).toString();
219219
{
@@ -253,7 +253,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF
253253
});
254254
});
255255

256-
describe.skip(FFOX)('BrowserContext({locale})', function() {
256+
describe.fail(FFOX)('BrowserContext({locale})', function() {
257257
it('should affect accept-language header', async({browser, server}) => {
258258
const context = await browser.newContext({ locale: 'fr-CH' });
259259
const page = await context.newPage();
@@ -307,7 +307,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF
307307
});
308308

309309
describe('focus', function() {
310-
it.skip(!headless)('should think that it is focused by default', async({page}) => {
310+
it.fail(!headless)('should think that it is focused by default', async({page}) => {
311311
expect(await page.evaluate('document.hasFocus()')).toBe(true);
312312
});
313313
});

‎test/evaluation.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT})
259259
expect(result).toEqual([42]);
260260
});
261261
// Works in WebKit, but slow
262-
it.skip(FFOX)('should transfer 100Mb of data from page to node.js', async({page, server}) => {
262+
it.fail(FFOX)('should transfer 100Mb of data from page to node.js', async({page, server}) => {
263263
const a = await page.evaluate(() => Array(100 * 1024 * 1024 + 1).join('a'));
264264
expect(a.length).toBe(100 * 1024 * 1024);
265265
});
@@ -425,7 +425,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT})
425425
const error = await page.evaluate(body => body.innerHTML, bodyHandle).catch(e => e);
426426
expect(error.message).toContain('Unable to adopt element handle from a different document');
427427
});
428-
it.skip(FFOX)('should return non-empty Node.constructor.name in utility context', async({page,server}) => {
428+
it.fail(FFOX)('should return non-empty Node.constructor.name in utility context', async({page,server}) => {
429429
await page.goto(server.EMPTY_PAGE);
430430
await utils.attachFrame(page, 'frame1', server.EMPTY_PAGE);
431431
const frame = page.frames()[1];

‎test/features/permissions.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ module.exports.describe = function({testRunner, expect, WEBKIT}) {
2727
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
2828

2929
// Permissions API is not implemented in WebKit (see https://developer.mozilla.org/en-US/docs/Web/API/Permissions_API)
30-
describe.skip(WEBKIT)('Permissions', function() {
30+
describe.fail(WEBKIT)('Permissions', function() {
3131
function getPermission(page, name) {
3232
return page.evaluate(name => navigator.permissions.query({name}).then(result => result.state), name);
3333
}

‎test/geolocation.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ module.exports.describe = function ({ testRunner, expect, FFOX, WEBKIT }) {
2323
const {it, fit, xit, dit} = testRunner;
2424
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
2525

26-
describe.skip(FFOX)('Overrides.setGeolocation', function() {
26+
describe.fail(FFOX)('Overrides.setGeolocation', function() {
2727
it('should work', async({page, server, context}) => {
2828
await context.setPermissions(server.PREFIX, ['geolocation']);
2929
await page.goto(server.EMPTY_PAGE);

‎test/headful.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ module.exports.describe = function({testRunner, expect, playwright, defaultBrows
4141
await removeUserDataDir(userDataDir);
4242
});
4343
// see https://github.com/microsoft/playwright/issues/717
44-
it.skip((WIN && CHROMIUM) || FFOX)('headless should be able to read cookies written by headful', async({server}) => {
44+
it.fail((WIN && CHROMIUM) || FFOX)('headless should be able to read cookies written by headful', async({server}) => {
4545
const userDataDir = await makeUserDataDir();
4646
// Write a cookie in headful chrome
4747
const headfulContext = await playwright.launchPersistent(userDataDir, headfulOptions);
@@ -59,7 +59,7 @@ module.exports.describe = function({testRunner, expect, playwright, defaultBrows
5959
await removeUserDataDir(userDataDir);
6060
expect(cookie).toBe('foo=true');
6161
});
62-
it.skip(FFOX)('should close browser with beforeunload page', async({server}) => {
62+
it.fail(FFOX)('should close browser with beforeunload page', async({server}) => {
6363
const userDataDir = await makeUserDataDir();
6464
const browserContext = await playwright.launchPersistent(userDataDir, headfulOptions);
6565
const page = await browserContext.newPage();

‎test/interception.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -524,7 +524,7 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p
524524
});
525525
});
526526

527-
describe.skip(FFOX)('Interception.setOfflineMode', function() {
527+
describe.fail(FFOX)('Interception.setOfflineMode', function() {
528528
it('should work', async({page, server}) => {
529529
await page.setOfflineMode(true);
530530
let error = null;

‎test/keyboard.spec.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT,
7878
await page.keyboard.sendCharacters('a');
7979
expect(await page.evaluate(() => document.querySelector('textarea').value)).toBe('嗨a');
8080
});
81-
it.skip(FFOX)('should report shiftKey', async({page, server}) => {
81+
it.fail(FFOX)('should report shiftKey', async({page, server}) => {
8282
await page.goto(server.PREFIX + '/input/keyboard.html');
8383
const keyboard = page.keyboard;
8484
const codeForKey = {'Shift': 16, 'Alt': 18, 'Control': 17};
@@ -241,7 +241,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT,
241241
await textarea.type('👹 Tokyo street Japan 🇯🇵');
242242
expect(await frame.$eval('textarea', textarea => textarea.value)).toBe('👹 Tokyo street Japan 🇯🇵');
243243
});
244-
it.skip(CHROMIUM && MAC)('should handle selectAll', async({page, server}) => {
244+
it.fail(CHROMIUM && MAC)('should handle selectAll', async({page, server}) => {
245245
await page.goto(server.PREFIX + '/input/textarea.html');
246246
const textarea = await page.$('textarea');
247247
await textarea.type('some text');
@@ -252,7 +252,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT,
252252
await page.keyboard.press('Backspace');
253253
expect(await page.$eval('textarea', textarea => textarea.value)).toBe('');
254254
});
255-
it.skip(CHROMIUM && MAC)('should be able to prevent selectAll', async({page, server}) => {
255+
it.fail(CHROMIUM && MAC)('should be able to prevent selectAll', async({page, server}) => {
256256
await page.goto(server.PREFIX + '/input/textarea.html');
257257
const textarea = await page.$('textarea');
258258
await textarea.type('some text');

‎test/launcher.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p
283283
// This might throw. See https://github.com/GoogleChrome/puppeteer/issues/2778
284284
await removeUserDataDir(userDataDir);
285285
});
286-
it.skip(FFOX)('userDataDir option should restore state', async({server}) => {
286+
it.fail(FFOX)('userDataDir option should restore state', async({server}) => {
287287
const userDataDir = await makeUserDataDir();
288288
const browserContext = await playwright.launchPersistent(userDataDir, defaultBrowserOptions);
289289
const page = await browserContext.newPage();
@@ -309,7 +309,7 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p
309309
await removeUserDataDir(userDataDir2);
310310
});
311311
// See https://github.com/microsoft/playwright/issues/717
312-
it.skip(FFOX || (WIN && CHROMIUM))('userDataDir option should restore cookies', async({server}) => {
312+
it.fail(FFOX || (WIN && CHROMIUM))('userDataDir option should restore cookies', async({server}) => {
313313
const userDataDir = await makeUserDataDir();
314314
const browserContext = await playwright.launchPersistent(userDataDir, defaultBrowserOptions);
315315
const page = await browserContext.newPage();

‎test/network.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ module.exports.describe = function({testRunner, expect, MAC, WIN, FFOX, CHROMIUM
231231
expect(responses[0].request()).toBeTruthy();
232232
});
233233

234-
it.skip(FFOX)('Page.Events.RequestFailed', async({page, server}) => {
234+
it.fail(FFOX)('Page.Events.RequestFailed', async({page, server}) => {
235235
server.setRoute('/one-style.css', (req, res) => {
236236
req.socket.write('deadbeef');
237237
req.socket.end();

‎test/page.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -667,7 +667,7 @@ module.exports.describe = function({testRunner, expect, headless, playwright, FF
667667
});
668668

669669
// Firefox fires onload for blocked script before it issues the CSP console error.
670-
it.skip(FFOX)('should throw when added with content to the CSP page', async({page, server}) => {
670+
it.fail(FFOX)('should throw when added with content to the CSP page', async({page, server}) => {
671671
await page.goto(server.PREFIX + '/csp.html');
672672
let error = null;
673673
await page.addScriptTag({ content: 'window.__injected = 35;' }).catch(e => error = e);

‎test/popup.spec.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
2020
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
2121

2222
describe('window.open', function() {
23-
it.skip(CHROMIUM)('should inherit user agent from browser context', async function({browser, server}) {
23+
it.fail(CHROMIUM)('should inherit user agent from browser context', async function({browser, server}) {
2424
const context = await browser.newContext({
2525
userAgent: 'hey'
2626
});
@@ -36,7 +36,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
3636
expect(userAgent).toBe('hey');
3737
expect(request.headers['user-agent']).toBe('hey');
3838
});
39-
it.skip(CHROMIUM)('should inherit extra headers from browser context', async function({browser, server}) {
39+
it.fail(CHROMIUM)('should inherit extra headers from browser context', async function({browser, server}) {
4040
const context = await browser.newContext({
4141
extraHTTPHeaders: { 'foo': 'bar' },
4242
});
@@ -48,7 +48,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
4848
await context.close();
4949
expect(request.headers['foo']).toBe('bar');
5050
});
51-
it.skip(CHROMIUM)('should inherit touch support from browser context', async function({browser, server}) {
51+
it.fail(CHROMIUM)('should inherit touch support from browser context', async function({browser, server}) {
5252
const context = await browser.newContext({
5353
viewport: { width: 400, height: 500, isMobile: true }
5454
});
@@ -61,7 +61,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
6161
await context.close();
6262
expect(hasTouch).toBe(true);
6363
});
64-
it.skip(CHROMIUM)('should inherit viewport size from browser context', async function({browser, server}) {
64+
it.fail(CHROMIUM)('should inherit viewport size from browser context', async function({browser, server}) {
6565
const context = await browser.newContext({
6666
viewport: { width: 400, height: 500 }
6767
});
@@ -74,7 +74,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
7474
await context.close();
7575
expect(size).toEqual({width: 400, height: 500});
7676
});
77-
it.skip(CHROMIUM)('should apply addInitScript from browser context', async function({browser, server}) {
77+
it.fail(CHROMIUM)('should apply addInitScript from browser context', async function({browser, server}) {
7878
const context = await browser.newContext();
7979
await context.addInitScript(() => window.injected = 123);
8080
const page = await context.newPage();
@@ -100,7 +100,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
100100
expect(await popup.evaluate(() => !!window.opener)).toBe(true);
101101
await context.close();
102102
});
103-
it.skip(CHROMIUM)('should work with empty url', async({browser}) => {
103+
it.fail(CHROMIUM)('should work with empty url', async({browser}) => {
104104
const context = await browser.newContext();
105105
const page = await context.newPage();
106106
const [popup] = await Promise.all([

0 commit comments

Comments
 (0)