Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eager mode for onnxscript #2011

Open
justinchuby opened this issue Jan 15, 2025 · 0 comments
Open

Eager mode for onnxscript #2011

justinchuby opened this issue Jan 15, 2025 · 0 comments
Labels
topic: discussion For discussion

Comments

@justinchuby
Copy link
Collaborator

justinchuby commented Jan 15, 2025

  1. Create an eager graph building mode
  2. The mode needs to be eager, aka the graph is built on the fly, instead of built lazily (?)
  3. Types for ONNX Script functions should pass mypy checks. This is important for adoption in other code bases because we don't want our users to disable their checks for onnx script
  4. We can create overloaded methods to handle numpy (concrete value) inputs. The inputs can also be ir.Tensor. Users should annotate the functions to take ir.Value or a derivative of this class (aka. onnxscript Tensor)
  5. Typing annotations should be simplified because parsing annotations and keeping up with different python versions is a pain. Instead, decorate the functions with onnxscript decorators and declare type information there, if needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: discussion For discussion
Projects
None yet
Development

No branches or pull requests

1 participant