Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Node.js and JavaScript formatting settings #67

Closed
mousetraps opened this issue Apr 13, 2015 · 2 comments
Closed

Consolidate Node.js and JavaScript formatting settings #67

mousetraps opened this issue Apr 13, 2015 · 2 comments

Comments

@mousetraps
Copy link
Contributor

This disparity in formatting options has caused confusion amongst some users. Node.js and JavaScript formatting settings have reached parity at this point. Is there any reason we might want to include separate settings for client-side and server-side JavaScript code?

I'm hesitant to simply remove Node.js formatting options and use JS because we still have different IntelliSense options for Node.js and JavaScript, and we don't want people to extrapolate from the formatting options that modifying JS IntelliSense will modify Node.js IntelliSense...

A few ideas:

  • Use same settings, but include formatting tab under Node.js options that directs user to JavaScript formatting settings (simply increasing visibility of formatting options.)
  • Include same formatting options under Node.js, but just have them linked to JavaScript settings (and include a note that this modifying Node.js options will modify JS options).
  • Use different settings, but include a "mirror JavaScript formatting options" button.
@ghost
Copy link

ghost commented Oct 3, 2015

I like the last option (keep using different settings with an option to mirror them).

@mousetraps
Copy link
Contributor Author

Closing as migrating to the new Salsa IntelliSense experience will be our path towards resolving this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant