Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding format and edit files breaks imports in TS projects using node module resolution #7

Closed
TedDriggs opened this issue Mar 7, 2018 · 3 comments
Assignees
Milestone

Comments

@TedDriggs
Copy link

After this commit, I'm unable to figure out how to get webpack to play nicely with this library.

Adding the dependency and doing nothing else, I get Uncaught Error: Cannot find module ".". If I suppress the require function using imports-loader, everything used to work, but now I get an error because require is no longer a function.

This may be an issue with my understanding of how Webpack/TS handle different module resolution strategies being used concurrently, but I'm now somewhat stuck.

@aeschli
Copy link
Contributor

aeschli commented Mar 12, 2018

I added ESM support: added a lib/esm folder, package.json-"module" points to that folder.
There was also a fix to break up the recursive dependency.

@aeschli aeschli closed this as completed Mar 12, 2018
@aeschli
Copy link
Contributor

aeschli commented Mar 12, 2018

@TedDriggs Let me know if all works for you...

@aeschli aeschli added this to the March 2018 milestone Mar 12, 2018
@TedDriggs
Copy link
Author

That worked perfectly; thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants