Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleMenuFlyoutItem and RadioMenuFlyoutItem do not show assigned icon in winui 2.6 prerelease #4473

Closed
lhak opened this issue Mar 10, 2021 · 4 comments · Fixed by #4587
Closed
Labels
area-Menus help wanted Issue ideal for external contributors team-Controls Issue for the Controls team
Milestone

Comments

@lhak
Copy link

lhak commented Mar 10, 2021

Describe the bug

When using the new styles for both controls, the assigned icon is ignored.

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Create a new winui 2.6 app and change the styles version to "latest"
  2. Add a ToggleMenuFlyoutItem or RadioMenuFlyoutItem
  3. Assign an icon to the item
  4. Observe that the icon is not shown

Expected behavior

Icon should be shown

Screenshots

Version Info

NuGet package version:

[Microsoft.UI.Xaml.2.6.0-prerelease.210227001]

Windows app type:

UWP Win32
Yes
Windows 10 version Saw the problem?
Insider Build (xxxxx)
October 2020 Update (19042) Yes
May 2020 Update (19041)
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Xbox
Surface Hub
IoT

Additional context

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Mar 10, 2021
@ranjeshj ranjeshj added this to the WinUI 2.6 milestone Mar 11, 2021
@ranjeshj ranjeshj added area-Menus team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Mar 11, 2021
@ranjeshj
Copy link
Contributor

@lhak can you paste a screenshot / markup ?

@StephenLPeters
Copy link
Contributor

@tashatitova and @ranjeshj it looks like we removed the ViewBox which was containing the icons on accident. Here is the line from the PR that removed it #3958 (comment)

@StephenLPeters StephenLPeters added the help wanted Issue ideal for external contributors label Mar 11, 2021
@tashatitova
Copy link
Contributor

@StephenLPeters @ranjeshj yes, accidental removal while cleaning up Reveal. Wasn't caught in testing. Need to add highlighted lines back.

@marcelwgn
Copy link
Collaborator

Taking a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Menus help wanted Issue ideal for external contributors team-Controls Issue for the Controls team
Projects
None yet
5 participants