Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabView will crash if no TabViewItem was added to TabItems in 2.5.0-prerelease.200923002 #3351

Closed
zhuxb711 opened this issue Sep 30, 2020 · 3 comments · Fixed by #3118
Closed

TabView will crash if no TabViewItem was added to TabItems in 2.5.0-prerelease.200923002 #3351

zhuxb711 opened this issue Sep 30, 2020 · 3 comments · Fixed by #3118
Labels
area-TabView team-Controls Issue for the Controls team

Comments

@zhuxb711
Copy link
Contributor

Describe the bug
TabView will crash if no TabViewItem was added to TabItems

Steps to reproduce the bug

  1. Do not add any TabViewItem to TabItems

Expected behavior
Should not crash

Screenshots

Version Info

NuGet package version:
[2.5.0-prerelease.200923002]

Windows app type:

UWP Win32
Yes
Windows 10 version Saw the problem?
Insider Build (xxxxx)
May 2020 Update (19041) Yes
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Xbox
Surface Hub
IoT

Additional context
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Sep 30, 2020
@zhuxb711 zhuxb711 mentioned this issue Sep 30, 2020
Merged
@Felix-Dev
Copy link
Contributor

Felix-Dev commented Sep 30, 2020 •
edited
Loading

@zhuxb711 This should be fixed by PR #3118 which is currently blocked from being merged due to down-level testing failures.

Edit: Confirmed.

@zhuxb711
Copy link
Contributor Author

@Felix-Dev OK, Got it, Thanks a lot.

@ghost ghost added the working on it label Sep 30, 2020
@StephenLPeters StephenLPeters added area-TabView team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Sep 30, 2020
@DHowett
Copy link
Member

DHowett commented Oct 29, 2020

Terminal is in an unfortunate position here. It needs many of the NavigationView fixes in later 2.5 prereleases, but can't move beyond the 2.5 June preview because of this crash. It's pretty much a full blocker on forward progress. :)

@ghost ghost removed the working on it label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-TabView team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
4 participants
@DHowett @Felix-Dev @StephenLPeters @zhuxb711