Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationView: The OverflowMenu button will not collapse when the overflow menu only contains one item and NavigationView menu items are removed to empty the overflow menu #3086

Closed
Felix-Dev opened this issue Aug 9, 2020 · 2 comments · Fixed by #3087
Labels
area-NavigationView NavView control team-Controls Issue for the Controls team

Comments

@Felix-Dev
Copy link
Contributor

Describe the bug
When the top NavigationView's overflow menu only contains a single menu item and

  • either removing that item or
  • removing menu item(s) to create enough room for the overflow menu item be displayed in the NavigationView pane area

will not collapse the OverflowMenu button (even though the overflow menu is now empty):

navview-overflowmenubutton

Expected behavior
The OverflowMenu button should be collapsed.

Version Info
NuGet package version:
Microsoft.UI.Xaml 2.5.0-prerelease.200708003
Microsoft.UI.Xaml 2.4.2

Windows 10 version Saw the problem?
Insider Build (xxxxx)
May 2020 Update (19041) Yes
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Xbox
Surface Hub
IoT
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Aug 9, 2020
@marcelwgn
Copy link
Collaborator

I think the issue here is that we simply forget to reevaluate the overflow menu situation when the list of NavigationViewItems changes.

@Felix-Dev
Copy link
Contributor Author

Felix-Dev commented Aug 9, 2020

@chingucoding Yes. (I am already working on a fix for this issue.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NavigationView NavView control team-Controls Issue for the Controls team
Projects
None yet
4 participants