Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationView: Top-level NavigationViewItem is not shown in Top PaneDisplayMode when one of its children is selected when switching to Top mode #2814

Closed
Felix-Dev opened this issue Jul 3, 2020 · 8 comments
Labels
area-NavigationView NavView control no-issue-activity team-Controls Issue for the Controls team

Comments

@Felix-Dev
Copy link
Contributor

Felix-Dev commented Jul 3, 2020

Describe the bug
When switching from a different PaneDisplayMode to Top PaneDisplayMode the top-level NavigationViewItem is not explicitly shown in the pane when it has a selected child.

Ignore the missing selection indicator, this is tracked in #2813.

Steps to reproduce the bug

  1. Open the MUXControlsTestApp
  2. Go the NavigationView tests page -> Hierarchical NavigationView Markup Test page
  3. Watch the GIF below:

navview-toppanedisplaymode-selecteditem-issue

Expected behavior

Menu Item 29 should be shown in Top PaneDisplayMode as its child is selected:
image

Version Info

NuGet package version:
Newest WinUI builds directly from the master branch.

Device form factor Saw the problem?
Desktop Yes
Xbox
Surface Hub
IoT

Additional context
This issue - as of now - will be fixed by PR #1997.

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jul 3, 2020
@Felix-Dev Felix-Dev changed the title NavigationView: Parent NavigationViewItem is not shown in Top PaneDisplayMode when one of its children is selected while switching to Top mode NavigationView: Top-level NavigationViewItem is not shown in Top PaneDisplayMode when one of its children is selected while switching to Top mode Jul 3, 2020
@Felix-Dev Felix-Dev changed the title NavigationView: Top-level NavigationViewItem is not shown in Top PaneDisplayMode when one of its children is selected while switching to Top mode NavigationView: Top-level NavigationViewItem is not shown in Top PaneDisplayMode when one of its children is selected when switching to Top mode Jul 3, 2020
@ranjeshj ranjeshj added area-NavigationView NavView control team-Controls Issue for the Controls team labels Jul 3, 2020
@StephenLPeters
Copy link
Contributor

Seems like a good bug. @ad1Dima I see you mentioned this but can't find the corresponding message. Does your change fix this?

@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Jul 8, 2020
@Felix-Dev
Copy link
Contributor Author

@StephenLPeters I ran the MUXControlsTestApp in @ad1Dima's branch and could not reproduce this error (see [Additional context] above).

@StephenLPeters
Copy link
Contributor

Ah, great, sorry I missed that.

@ad1Dima
Copy link
Contributor

ad1Dima commented Aug 6, 2020

@StephenLPeters i guess this can be closed also

@StephenLPeters
Copy link
Contributor

Fixed by #1997

@Felix-Dev
Copy link
Contributor Author

Felix-Dev commented Aug 11, 2020

Hmm, not sure what happened here but I can still repro this issue on newest WinUI master builds:

navview-toplevel-selecteditem-display-issue

The expected result would be that Menu Item 29 is visible and selected when switching back to top navigation after selecting its child item.

@StephenLPeters
Copy link
Contributor

Dang, I'd say lets reopen the issue but looks like I never closed it. Maybe my subconscious knew it wasn't resolved

@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NavigationView NavView control no-issue-activity team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

5 participants