Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Darken the background color of active textboxes in dark mode #2068

Closed
skyanchor opened this issue Mar 5, 2020 · 6 comments
Closed
Labels
area-TextBox TextBox, RichEditBox discussion General discussion

Comments

@skyanchor
Copy link

Discussion: Darken the background color of active textboxes in dark mode

The background color of a windows page is usually black or dark gray when in dark mode. A white colored textbox might be too flashy, especially when the textbox is wide and large, say the ones in feedback hub.
One possible workaround is setting the background color a little lighter than one for the page background, and put the text inside the textbox white.

Related Links

@skyanchor skyanchor added the discussion General discussion label Mar 5, 2020
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Mar 5, 2020
@mdtauk
Copy link
Contributor

mdtauk commented Mar 5, 2020

I would rather the default ApplicationPageBackground colour be changed to a very Dark Grey, instead of pure black. #807 #920

@marcelwgn
Copy link
Collaborator

I think what @skyanchor refers to is more like #2046 and #142 .

@mdtauk
Copy link
Contributor

mdtauk commented Mar 5, 2020

I think what @skyanchor refers to is more like #2046 and #142 .

In which case he is going to be happy soon :)

@JohnnyWestlake
Copy link

I would rather the default ApplicationPageBackground colour be changed to a very Dark Grey, instead of pure black. #807 #920

As someone with an OLED laptop, I really pray this doesn't happen. I get enough of this useless dark mode from Google on my Android phone with all it's dark greys rather than black 😅

@mdtauk
Copy link
Contributor

mdtauk commented Mar 5, 2020

I would rather the default ApplicationPageBackground colour be changed to a very Dark Grey, instead of pure black. #807 #920

As someone with an OLED laptop, I really pray this doesn't happen. I get enough of this useless dark mode from Google on my Android phone with all it's dark greys rather than black 😅

Issue #807 which I submitted, calls out OLED as a possible exception

@ranjeshj ranjeshj added area-TextBox TextBox, RichEditBox team-Framework and removed needs-triage Issue needs to be triaged by the area owners labels Mar 5, 2020
@chigy
Copy link
Member

chigy commented May 8, 2020

This is now fixed.
https://docs.microsoft.com/en-us/uwp/toolkits/winui/release-notes/winui-2.4

@chigy chigy closed this as completed May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TextBox TextBox, RichEditBox discussion General discussion
Projects
None yet
Development

No branches or pull requests

7 participants