Samwelkanda/python/kiota abstractions setup #925
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
samwelkanda
requested review from
andrueastman,
darrelmiller,
ddyett,
MIchaelMainer,
nikithauc,
peombwa,
ramsessanchez and
zengin
as code owners
Updated in dfc5583 |
README.md
Outdated
| | TypeScript/JavaScript | [✔](https://github.com/microsoft/kiota/projects/2) | [✔](./abstractions/typescript) | [JSON](./serialization/typescript/json) | [Anonymous](./abstractions/typescript/src/authentication/anonymousAuthenticationProvider.ts), [Azure](./authentication/typescript/azure) | [✔](./http/typescript/fetch) | [link](https://microsoft.github.io/kiota/get-started/typescript) | | ||
| | Language | Generation | Abstractions | Serialization | Authentication | HTTP | Required tools & dependencies | | ||
| | -------- | ---------- | ------------ | ------------- | -------------- | ---- | -------------- | | ||
| | CSharp | [✔](https://github.com/microsoft/kiota/projects/5) | [✔](./abstractions/dotnet) | [JSON](./serialization/dotnet/json) | [Anonymous](./abstractions/dotnet/src/authentication/AnonymousAuthenticationProvider.cs), [Azure](./authentication/dotnet/azure) | [✔](./http/dotnet/httpclient) | [link](./docs/requiredtools/dotnet.md) | |
There was a problem hiding this comment.
Please revert that change and put back the links to the github.io site when available (dotnet, java, go, ruby, typescript)
There was a problem hiding this comment.
but just to be clear, this page still needs to be updated for the Python row
|
also another things that's missing in that batch of PRs is a github actions worklfow to build the library. |
samwelkanda
force-pushed
the
samwelkanda/python/kiota-abstractions-setup
branch
from
6fef336 to
e143023
Compare
| run: flit publish | ||
| working-directory: ${{ env.relativePath }} | ||
| env: | ||
| FLIT_INDEX_URL: https://upload.pypi.org/legacy/ |
There was a problem hiding this comment.
Yes, that is the link to public index. It just happens to be named "legacy".
There was a problem hiding this comment.
I don't think we should publish to the public index just yet in case we need to make breaking changes. Github packages doesn't seem to support Python.
May I suggest we create a new a ADO package feed and use that instead for the time being? https://microsoftgraph.visualstudio.com/Graph%20Developer%20Experiences/_packaging?_a=feed&feed=PowerShellSDK_BuildFeed
There was a problem hiding this comment.
Ok. What if we publish to the test Index https://test.pypi.org for now then?
There was a problem hiding this comment.
this one is public I assume? but it's understood by the community that things on this index are not meant for production, correct? and can we pull a package entirely from that index? (I'm thinking of the case where we change the name of the package).
If the answer to both question is yes, please proceed.
There was a problem hiding this comment.
Yes, that is the case.
There was a problem hiding this comment.
Thanks for making the change! Let me know if you need tme to add secrets to the repo
There was a problem hiding this comment.
I will. I currently don't have the privileges to add the secrets myself (can't access the project settings).
samwelkanda
force-pushed
the
samwelkanda/python/kiota-abstractions-setup
branch
from
3ff66d6 to
bb24e21
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
partial #367