-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add auth into plugin generation #5209
Conversation
allow falling back to the global security if the operation has none.
# Conflicts: # src/Kiota.Builder/Plugins/PluginsGenerationService.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes!
…ity' into caleb/feat/plugin-manifest-security
@baywet, the test is failing for 1 of the ACs, because of a gap in OpenAPI. I'll open an issue in the OpenAPI.NET repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my end.
You'll need to run dotnet format
for the linting in the CI to pass.
Could we also add a changelog entry for this change as well?
add tests
# Conflicts: # CHANGELOG.md # src/Kiota.Builder/Configuration/GenerationConfiguration.cs # tests/Kiota.Builder.Tests/Plugins/PluginsGenerationServiceTests.cs
…es not contain the provided authentication
Note for reviewers: The feature to use global security information if local operation security is not provided is waiting on resolution of microsoft/OpenAPI.NET#1797 |
src/Kiota.Builder/WorkspaceManagement/ApiPluginConfigurationComparer.cs
Outdated
Show resolved
Hide resolved
@baywet, I think the logic of |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes!
for others reading, we discussed that internally. And a better implementation would be to instead use HashCode. This is a broader change and we don't want to delay the plugins auth for that though. Caleb will create a separate PR to address it across the board. |
See #5070