Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds go generation and go abstractions #413

Merged
merged 76 commits into from
Aug 18, 2021
Merged

adds go generation and go abstractions #413

merged 76 commits into from
Aug 18, 2021

Conversation

baywet
Copy link
Member

@baywet baywet commented Jul 27, 2021 •
edited
Loading

Summary

  • initial setup for go generation
  • adds go profile to launch.json
  • fixes package declaration for go
  • adds go abstractions
  • fixes go file name conventions
  • adds support for enums in go
  • adds support for usings in go
  • fixes primitive type mapping in go
  • removes private fields prefixing in go as it's handled by language conventions
  • adds default imports, relative imports and core types correction in go
  • updates go launch json to match language conventions

fixes #161

Generation result

microsoft/kiota-samples#176

TODO

  • Client constructor
  • Collection navigation properties (e.g. get all messages)
  • Unit tests

@baywet baywet added this to the Beta milestone Jul 27, 2021
@baywet baywet added the Go label Jul 27, 2021
@baywet baywet self-assigned this Jul 27, 2021
Base automatically changed from feature/ruby-writers to main July 28, 2021 16:08
@baywet baywet force-pushed the feature/go branch 2 times, most recently from bef594e to b5e04fa Compare August 4, 2021 14:41
@baywet baywet force-pushed the feature/go branch 2 times, most recently from 3384f01 to aefaaae Compare August 5, 2021 13:44
This was referenced Aug 10, 2021
Closed
Closed
Closed
Closed
This was referenced Aug 10, 2021
Closed
Closed
@baywet baywet marked this pull request as ready for review August 11, 2021 19:08
@baywet baywet enabled auto-merge August 11, 2021 19:08
@baywet baywet removed the request for review from abfarah August 16, 2021 15:15
baywet added 20 commits August 17, 2021 12:18
@baywet
- adds support for request builder navigation properties in go
a45d2ef
@baywet
- adds support for middleware options in code-generation for go
e1ffa74
@baywet
- adds a worfklow for go abstractions
7305745
@baywet
- adds missing working directory instruction for go
1744586
@baywet
- code linting
5ef18ae
@baywet
- adds integration and refiner tests for Go
8c89e6e
@baywet
- adds code property tests for go
da74a69
@baywet
- adds code enum writer tests for go
c616111
@baywet
- minor casing fix for go property writer unit test
0b0d681
@baywet
- adds changelog entry for go generation
0d1e9ff
@baywet
- adds code class declaration witer tests for go
1c3dfba
@baywet
- adds code method writer unit tests for Go
778caf2
@baywet
- code-linting: defensive programing in go method writer
2f91654
@baywet
- fixes a race condition in go refiners
cfd5687
@baywet
- improves code coverage for go generation
3bdd926
@baywet
- adds dependebaot configurations for go abstractions
642e7fc
@baywet
- aligns set content from parsable parameters order to changes from #…
fb3f030 
…480
@baywet
- updates samples reference
02ccdd6
@baywet
- fixes an issue after merge where go writers would still use the rem…
342f632 
…oved boolean backing store parameter
@baywet
- addresses pull request comments
448f9ea
@baywet baywet requested a review from andrueastman August 17, 2021 16:40
@baywet baywet requested a review from andrueastman August 17, 2021 19:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

83.8% 83.8% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit 913f5c5 into main Aug 18, 2021
@baywet baywet deleted the feature/go branch August 18, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@peombwa peombwa Awaiting requested review from peombwa

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@zengin zengin Awaiting requested review from zengin

Assignees

@baywet baywet

Labels
Go
Projects
None yet
Milestone
Alpha-2
Development

Successfully merging this pull request may close these issues.

Go generation support
2 participants
@baywet @andrueastman