Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Self expansion of query parameters instead of using reflection #3982

Merged
merged 12 commits into from
Jan 10, 2024

Conversation

andreaTP
Copy link
Contributor

@andreaTP andreaTP commented Jan 9, 2024

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions!
A couple of small change suggestions

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

baywet
baywet previously approved these changes Jan 9, 2024
@baywet baywet marked this pull request as ready for review January 9, 2024 15:28
@baywet baywet requested a review from a team as a code owner January 9, 2024 15:28
@baywet baywet enabled auto-merge January 9, 2024 15:28
auto-merge was automatically disabled January 9, 2024 15:34

Pull Request is not mergeable

@andreaTP
Copy link
Contributor Author

andreaTP commented Jan 9, 2024

@baywet , missed to fix an Integration Test, should be good now.

baywet
baywet previously approved these changes Jan 9, 2024
@baywet
Copy link
Member

baywet commented Jan 9, 2024

On the PHP failures, disregard them. It seems to be a regression in our dependencies and our team is already investigating that.
On the inability to pull the latest of kiota java, this is strange since I released them earlier. I'm currently on my phone, are you able to run things locally?

@andreaTP
Copy link
Contributor Author

andreaTP commented Jan 9, 2024

On the PHP failures, disregard them.

ok 👍

On the inability to pull the latest of kiota java, this is strange since I released them earlier. I'm currently on my phone, are you able to run things locally?

Maven Central has not synced yet: https://repo1.maven.org/maven2/com/microsoft/kiota/microsoft-kiota-abstractions/
It can take minutes to hours(a day in the very worst situations).

@baywet
Copy link
Member

baywet commented Jan 9, 2024

still not available. created an issue to flag this to the team https://issues.sonatype.org/browse/MVNCENTRAL-8604

@andreaTP
Copy link
Contributor Author

andreaTP commented Jan 9, 2024

Not yet, it would not be the first time ... but I have to admit it's pretty bad 😞
Have you checked the release pipelines and logged in the Sonatype account?

@baywet
Copy link
Member

baywet commented Jan 10, 2024

I'm not sure why it's not on this repo, but it seems to be available for consumption as this dependabot PR would lead me to think. Let me try to queue things again
microsoft/kiota-samples#4759

@baywet
Copy link
Member

baywet commented Jan 10, 2024

Yep, it seems to be working now besides the missing entries in the repo.
We still are facing a couple of integration tests fails like this one which look related to the current set of changes. Do you mind having a look when you have a couple of minutes please?

@andreaTP
Copy link
Contributor Author

I'll take a look later on today 👍

@andreaTP
Copy link
Contributor Author

@baywet the it tests failures should be fixed now: 09b046b

@andreaTP
Copy link
Contributor Author

I don't understand why the download-artifact action is failing here, should we report a bug?

@baywet
Copy link
Member

baywet commented Jan 10, 2024

yep, it's been going on for a month actions/download-artifact#249 they just pushed a patch today, hopefully in the next couple of days we should not see those anymore

@baywet baywet merged commit 41efcb7 into microsoft:main Jan 10, 2024
185 of 186 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java - Self expansion of QueryParameters without reflection
2 participants