-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Self expansion of query parameters instead of using reflection #3982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contributions!
A couple of small change suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes!
@baywet , missed to fix an Integration Test, should be good now. |
On the PHP failures, disregard them. It seems to be a regression in our dependencies and our team is already investigating that. |
ok 👍
Maven Central has not synced yet: https://repo1.maven.org/maven2/com/microsoft/kiota/microsoft-kiota-abstractions/ |
still not available. created an issue to flag this to the team https://issues.sonatype.org/browse/MVNCENTRAL-8604 |
Not yet, it would not be the first time ... but I have to admit it's pretty bad 😞 |
I'm not sure why it's not on this repo, but it seems to be available for consumption as this dependabot PR would lead me to think. Let me try to queue things again |
Yep, it seems to be working now besides the missing entries in the repo. |
I'll take a look later on today 👍 |
Co-authored-by: Vincent Biret <[email protected]>
Co-authored-by: Vincent Biret <[email protected]>
Co-authored-by: Vincent Biret <[email protected]>
Co-authored-by: Vincent Biret <[email protected]>
I don't understand why the |
yep, it's been going on for a month actions/download-artifact#249 they just pushed a patch today, hopefully in the next couple of days we should not see those anymore |
Fix #3965
Depends on:
microsoft/kiota-java#991