- fixes a bug with path items deduplication #3760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
force-pushed
the
bugfix/param-path-deduplication
branch
from
d1292c0 to
4c668a2
Compare
|
Kudos, SonarCloud Quality Gate passed! |
andrueastman
approved these changes
Nov 22, 2023
ttoth89
reviewed
Dec 13, 2023
| @@ -6390,12 +6409,17 @@ public void SinglePathParametersAreDeduplicated() | |||
| Assert.NotNull(managerRB); | |||
| var managerUrlTemplate = managerRB.FindChildByName<CodeProperty>("UrlTemplate", false); | |||
| Assert.NotNull(managerUrlTemplate); | |||
| Assert.Equal("{+baseurl}/users/{id}/manager", managerUrlTemplate.DefaultValue.Trim('"')); | |||
| Assert.Equal("{+baseurl}/users/{users%2Did}/manager", managerUrlTemplate.DefaultValue.Trim('"')); | |||
There was a problem hiding this comment.
@baywet after updating to kiota 1.9.0 from preview this is causing a regression
in my swagger file i have: files/{fileid}/dependencies
- this generates template:
{+baseurl}/files/{files%2Did}/dependencies - when calling
_api.Files[123].Dependencies.GetAsync()the url template parameters still hasfileid:123
Eventually GET api/files//dependencies is called and the request fails
Any suggestion for this case?
There was a problem hiding this comment.
Thanks for pointing this. Can you join the conversation at #3901 please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3757