Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2488 - Add using statement for EnumMember attribute #2494

Merged
merged 1 commit into from
Mar 31, 2023
Merged

#2488 - Add using statement for EnumMember attribute #2494

merged 1 commit into from
Mar 31, 2023

Conversation

vadrsa
Copy link

@vadrsa vadrsa commented Mar 31, 2023

No description provided.

@vadrsa vadrsa mentioned this pull request Mar 31, 2023
Closed
@vadrsa vadrsa force-pushed the add-using-for-enum-member branch from 0f1c532 to 36878c6 Compare March 31, 2023 08:51
baywet
baywet requested changes Mar 31, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up. This is something that's added by the refiner to ease up the maintenance. See

kiota/src/Kiota.Builder/Refiners/CSharpRefiner.cs

Line 131 in a126b72

new (static x => x is CodeProperty prop && prop.IsOfKind(CodePropertyKind.RequestAdapter),

Can you update your PR to follow the pattern please?

@baywet baywet linked an issue Mar 31, 2023 that may be closed by this pull request
CSharp | Enum values are invalid after being sanitized #2488
Closed
@vadrsa vadrsa force-pushed the add-using-for-enum-member branch from 36878c6 to 3ea2c64 Compare March 31, 2023 17:05
@vadrsa
Copy link
Author

vadrsa commented Mar 31, 2023

Thanks for the follow up. This is something that's added by the refiner to ease up the maintenance. See

kiota/src/Kiota.Builder/Refiners/CSharpRefiner.cs

Line 131 in a126b72

new (static x => x is CodeProperty prop && prop.IsOfKind(CodePropertyKind.RequestAdapter),

Can you update your PR to follow the pattern please?

Fixed

@vadrsa vadrsa requested a review from baywet March 31, 2023 17:05
baywet
baywet approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@baywet baywet enabled auto-merge March 31, 2023 17:31
@baywet baywet merged commit b53d2b4 into microsoft:main Mar 31, 2023
@baywet baywet mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman Awaiting requested review from andrueastman

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@calebkiage calebkiage Awaiting requested review from calebkiage

@Ndiritu Ndiritu Awaiting requested review from Ndiritu

@rkodev rkodev Awaiting requested review from rkodev

@gavinbarron gavinbarron Awaiting requested review from gavinbarron

@coseguera coseguera Awaiting requested review from coseguera

@koros koros Awaiting requested review from koros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSharp | Enum values are invalid after being sanitized
3 participants
@vadrsa @baywet @davit-asryan-veritas